Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Feature Request: Change how auto-login works #1063
Brief summary of issue / Description of requested feature:
Currently the auto-login feature is asymmetric:
Case 4. should behave as 2.
Steps to reproduce the issue / Reasons for adding feature:
Error output / Expected result of feature
The original reason for the auto-login is to avoid the case of having to log in twice (once for website and once for webclient). While one could argue that there is a potential advantage to be able to just auto-login to the webclient if still logged into the website, now logging out is a two-step process instead, where one has to go to the website in order to actually be able to login anew to the webclient. In short, logging out of the webclient should also log one out of the website.
Extra information, such as Evennia revision/repo/branch, operating system and ideas for how to solve / implement:
Whereas the other issues have been closed, actually implementing this is more complex than expected. Notably because the webclient must somehow track so that it does not log out of the website if there are remaining (webclient-)Sessions connected; which is not immediately obvious how to determine.
It could, but it's not really up to the webclient itself to handle this I don't think, but the webclient's backend.
I did try querying the session count connected to a given player as my first attempt but ran into edge cases with the implementation. Will likely revisit to see if I can figure out a stable way to do it.