Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup MSSQL packages #204

Merged
merged 12 commits into from Jun 14, 2016

Conversation

2 participants
@rasmus
Copy link
Member

commented Feb 21, 2016

The MSSQL packages for EventFlow currently consists of these

  • EventFlow.MsSql
  • EventFlow.EventStores.MsSql
  • EventFlow.ReadStores.MsSql

This pull request will investigate the possibility of merging all three into one single EventFlow.MsSql package, similar to the recently added support for SQLite.

Its important that the only breaking changes to this merge of NuGet packages is on compile time and the required changes should be as simple as ReSharper ALT+Enter and then Enter (import missing reference).

@codecov-io

This comment has been minimized.

Copy link

commented Apr 8, 2016

Current coverage is 82.20%

Merging #204 into develop will not affect coverage as of 45910e6

@@            develop   #204   diff @@
======================================
  Files           215    216     +1
  Stmts          3180   3186     +6
  Branches        292    293     +1
  Methods           0      0       
======================================
+ Hit            2614   2619     +5
- Partial         173    174     +1
  Missed          393    393       

Review entire Coverage Diff as of 45910e6


Uncovered Suggestions

  1. +0.38% via ...ore/GuidFactories.cs#40...51
  2. +0.25% via ...sEventPersistence.cs#236...243
  3. +0.16% via ...teStoreExtensions.cs#80...84
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

rasmus added some commits Apr 14, 2016

Merge branch 'develop' into cleanup-mssql-packages
# Conflicts:
#	Source/EventFlow.MsSql.Tests/IntegrationTests/ReadStores/MsSqlReadModelStoreTests.cs
#	Source/EventFlow.MsSql/EventFlow.MsSql.csproj
#	Source/EventFlow.MsSql/EventStores/MsSqlEventPersistence.cs

@rasmus rasmus merged commit 518a619 into develop Jun 14, 2016

1 check passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details

@rasmus rasmus deleted the cleanup-mssql-packages branch Jun 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.