SSLSocket.accept fails when monkey-patched #651
Currently setting up a fairly simple SSL server and I wanted to use eventlet to spawn handler threads for the clients. Unfortunately, if I use
The monkey-patching happens right at the top of the file:
import eventlet eventlet.monkey_patch()
To create the SSL socket, I don't use
context = ssl.SSLContext(ssl.PROTOCOL_TLSv1_2) context.load_cert_chain(certfile="server.crt", keyfile="server.key")
Then I wrap the socket:
sock = socket.create_server(('0.0.0.0', 1234)) ssl_sock = context.wrap_socket(sock, server_side=True)
And finally, I call
The text was updated successfully, but these errors were encountered:
@Xandaros thank you, that's a shame to fail such basic interaction. Sorry.
I've found the culprit of problem, it's a one line fix, but I'm afraid it may potentially break a lot of other things. So asking you to participate in as extensive testing as you can afford before it may be released to public. Please read shortest instruction and report problems here #655
Due to time constraints I had to move away from eventlet, so I don't actually have a use-case to test this on, sorry.
At this point it would be too much work to move everything back to eventlet, especially when using an unpublished version we wouldn't be able to deploy.
68: Update eventlet to 0.29.1 r=duckinator a=pyup-bot This PR updates [eventlet](https://pypi.org/project/eventlet) from **0.28.0** to **0.29.1**. <details> <summary>Changelog</summary> ### 0.29.1 ``` ====== patcher: [py27] recursion error in pytest/python2.7 installing register_at_fork eventlet/eventlet#660 patcher: monkey_patch(builtins=True) failed on py3 because `file` class is gone eventlet/eventlet#541 don't crash on PyPy 7.0.0 eventlet/eventlet#547 Only install monotonic on python2 eventlet/eventlet#583 ``` ### 0.29.0 ``` ====== * ssl: context wrapped listener fails accept() eventlet/eventlet#651 ``` ### 0.28.1 ``` ====== * Sorry, Eventlet was broken on Windows for versions 0.27-0.28 patcher: no os.register_at_fork on Windows (654) * Clean up TypeError in __del__ ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/eventlet - Changelog: https://pyup.io/changelogs/eventlet/ - Homepage: http://eventlet.net </details> Co-authored-by: pyup-bot <email@example.com>