Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maximum recursion depth exceeded error in monkey_patch #660

Closed
lobsterkatie opened this issue Oct 20, 2020 · 2 comments
Closed

maximum recursion depth exceeded error in monkey_patch #660

lobsterkatie opened this issue Oct 20, 2020 · 2 comments

Comments

@lobsterkatie
Copy link

@lobsterkatie lobsterkatie commented Oct 20, 2020

Hello!

This PR, merged yesterday, removed a version check on Python, and now running under 2.7 (which we do as part of our test suite) throws this error:

_______ ERROR at setup of test_transport_works[eventlet-True-close-True] _______
tests/conftest.py:292: in maybe_monkeypatched_threading
    eventlet.monkey_patch()
.tox/py2.7/lib/python2.7/site-packages/eventlet/patcher.py:316: in monkey_patch
    _os = original('os')
.tox/py2.7/lib/python2.7/site-packages/eventlet/patcher.py:201: in original
    real_mod = __import__(modname, {}, {}, modname.split('.')[:-1])
.tox/py2.7/lib/python2.7/fnmatch.py:40: in fnmatch
    import os
.tox/py2.7/lib/python2.7/fnmatch.py:40: in fnmatch
    import os
E   RuntimeError: maximum recursion depth exceeded in __instancecheck__
!!! Recursion detected (same locals & position)

That version check was added here. Is it incompatible with the change made yesterday, or could it be added back in?

Thanks!

lobsterkatie added a commit to getsentry/sentry-python that referenced this issue Oct 20, 2020
temoto added a commit that referenced this issue Oct 21, 2020
…er_at_fork

#660
getsentry/sentry-python#880

Could not reproduce problem without pytest, so normal production code was probably safe.
temoto added a commit that referenced this issue Oct 21, 2020
…er_at_fork

#660
getsentry/sentry-python#880

Could not reproduce problem without pytest, so normal production code was probably safe.
temoto added a commit that referenced this issue Oct 21, 2020
…er_at_fork

#660
getsentry/sentry-python#880

Could not reproduce problem without pytest, so normal production code was probably safe.
temoto added a commit that referenced this issue Oct 22, 2020
…er_at_fork

#660
getsentry/sentry-python#880

Could not reproduce problem without pytest, so normal production code was probably safe.
temoto added a commit that referenced this issue Oct 22, 2020
…er_at_fork

#660
getsentry/sentry-python#880

Could not reproduce problem without pytest, so normal production code was probably safe.
temoto added a commit that referenced this issue Oct 22, 2020
…er_at_fork

#660
getsentry/sentry-python#880

Could not reproduce problem without pytest, so normal production code was probably safe.
@temoto temoto closed this in #661 Oct 22, 2020
@temoto
Copy link
Member

@temoto temoto commented Oct 22, 2020

Fixed in 0.29.1

@lobsterkatie
Copy link
Author

@lobsterkatie lobsterkatie commented Oct 22, 2020

Thanks for the quick turn-around!

bors bot added a commit to duckinator/parts.horse that referenced this issue Oct 24, 2020
Merge #68
68: Update eventlet to 0.29.1 r=duckinator a=pyup-bot


This PR updates [eventlet](https://pypi.org/project/eventlet) from **0.28.0** to **0.29.1**.



<details>
  <summary>Changelog</summary>
  
  
   ### 0.29.1
   ```
   ======
patcher: [py27] recursion error in pytest/python2.7 installing register_at_fork eventlet/eventlet#660
patcher: monkey_patch(builtins=True) failed on py3 because `file` class is gone eventlet/eventlet#541
don&#39;t crash on PyPy 7.0.0 eventlet/eventlet#547
Only install monotonic on python2 eventlet/eventlet#583
   ```
   
  
  
   ### 0.29.0
   ```
   ======
* ssl: context wrapped listener fails accept() eventlet/eventlet#651
   ```
   
  
  
   ### 0.28.1
   ```
   ======
* Sorry, Eventlet was broken on Windows for versions 0.27-0.28
  patcher: no os.register_at_fork on Windows (654)
* Clean up TypeError in __del__
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/eventlet
  - Changelog: https://pyup.io/changelogs/eventlet/
  - Homepage: http://eventlet.net
</details>



Co-authored-by: pyup-bot <github-bot@pyup.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants