-
Notifications
You must be signed in to change notification settings - Fork 330
Fix ssl test when linking against openssl 3.5+ #1034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Openssl 3.5 changed some error propagations. As a result, sometimes instead of SSL_Error we get a Broken Pipe. Update the ssl_test to handle that.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1034 +/- ##
======================================
Coverage 56% 56%
======================================
Files 89 89
Lines 9852 9852
Branches 1772 1772
======================================
+ Hits 5575 5577 +2
+ Misses 3913 3912 -1
+ Partials 364 363 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hello, Thanks for reporting this issue. |
|
We discovered this when trying to upgrade openssl to 3.5 in openSUSE Tubmleweed. Here's a a build log without the patch: [ Here's a log with the patch applied and all tests passing: https://build.opensuse.org/package/live_build_log/devel:languages:python/python-eventlet/openSUSE_Tumbleweed/x86_64 |
|
Thanks for details. |
|
Hm, apparently we face problems with the pypy jobs. This jobs seems canceled, I don't know why and no logs are available. I need to dig further to see what happen, because this job is required, and so it block our merging. |
|
confirmed on our end as well. This fixes the tests on Fedora Rawhide that uses openssl-3.5.0 |
|
I made several jobs relaunch attempts and the pypy jobs is still failing without real reason. |
|
Unfortunatelly #1035 is not enough... |
Openssl 3.5 changed some error propagations. As a result, sometimes instead of SSL_Error we get a Broken Pipe. Update the ssl_test to handle that.