Skip to content

Fix ssl test when linking against openssl 3.5+ #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

yankov-pt
Copy link
Contributor

Openssl 3.5 changed some error propagations. As a result, sometimes instead of SSL_Error we get a Broken Pipe. Update the ssl_test to handle that.

Openssl 3.5 changed some error propagations. As a result,
sometimes instead of SSL_Error we get a Broken Pipe. Update the ssl_test
to handle that.
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56%. Comparing base (3ec6317) to head (0c16bda).
Report is 4 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1034   +/-   ##
======================================
  Coverage      56%     56%           
======================================
  Files          89      89           
  Lines        9852    9852           
  Branches     1772    1772           
======================================
+ Hits         5575    5577    +2     
+ Misses       3913    3912    -1     
+ Partials      364     363    -1     
Flag Coverage Δ
ipv6 23% <ø> (ø)
py310asyncio 53% <ø> (+<1%) ⬆️
py310epolls 53% <ø> (ø)
py310poll 53% <ø> (ø)
py310selects 53% <ø> (+<1%) ⬆️
py311asyncio 53% <ø> (+<1%) ⬆️
py311epolls 53% <ø> (ø)
py312asyncio 51% <ø> (-1%) ⬇️
py312epolls 51% <ø> (+<1%) ⬆️
py313asyncio 51% <ø> (-1%) ⬇️
py313epolls 51% <ø> (ø)
py38asyncio 51% <ø> (+<1%) ⬆️
py38epolls 53% <ø> (ø)
py38openssl 51% <ø> (+<1%) ⬆️
py38poll 53% <ø> (ø)
py38selects 53% <ø> (+<1%) ⬆️
py39asyncio 51% <ø> (+<1%) ⬆️
py39dnspython1 51% <ø> (ø)
py39epolls 53% <ø> (+<1%) ⬆️
py39poll 53% <ø> (ø)
py39selects 53% <ø> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@4383
Copy link
Member

4383 commented Apr 22, 2025

Hello,

Thanks for reporting this issue.
Is there a way to reproduce the behaviour you observed?

@yankov-pt
Copy link
Contributor Author

We discovered this when trying to upgrade openssl to 3.5 in openSUSE Tubmleweed.

Here's a a build log without the patch: [
eventlet-build-fail.log
](url)

Here's a log with the patch applied and all tests passing: https://build.opensuse.org/package/live_build_log/devel:languages:python/python-eventlet/openSUSE_Tumbleweed/x86_64

@4383
Copy link
Member

4383 commented Apr 22, 2025

Thanks for details.

@4383
Copy link
Member

4383 commented Apr 22, 2025

Hm, apparently we face problems with the pypy jobs. This jobs seems canceled, I don't know why and no logs are available. I need to dig further to see what happen, because this job is required, and so it block our merging.

@paulwouters
Copy link

confirmed on our end as well. This fixes the tests on Fedora Rawhide that uses openssl-3.5.0

@4383
Copy link
Member

4383 commented Apr 28, 2025

I made several jobs relaunch attempts and the pypy jobs is still failing without real reason.
I created a merge request to make the pypy job optional #1035 and hence being able to merge your patch.

@4383
Copy link
Member

4383 commented Apr 29, 2025

Unfortunatelly #1035 is not enough...
We have to disable this canceled job at the repository settings level, but for now we are not granted to do that.

@4383 4383 mentioned this pull request May 12, 2025
@4383 4383 merged commit bd1cabb into eventlet:master May 13, 2025
69 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants