Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix monkey-patched os.open(): add dir_fd parameter #170

Closed
wants to merge 1 commit into from

Conversation

@vstinner
Copy link
Contributor

vstinner commented Nov 27, 2014

The os.open() function got a new option keyword-only dir_fd parameter in
Python 3.3:
https://docs.python.org/3/library/os.html#os.open

With this change, the open() now accepts the dir_fd parameter.

For example, the dir_fd parameter is used by shutil.rmtree() for safety:
https://docs.python.org/3/library/shutil.html#shutil.rmtree
"Changed in version 3.3: Added a symlink attack resistant version that is used automatically if platform supports fd-based functions."

The os.open() function got a new option keyword-only dir_fd parameter in
Python 3.3:
https://docs.python.org/3/library/os.html#os.open

With this change, the open() now accepts the dir_fd parameter.
@temoto

This comment has been minimized.

Copy link
Member

temoto commented Dec 22, 2014

Thank you, it's merged in master.

@temoto temoto closed this Dec 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.