Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix monkey-patched os.open(): add dir_fd parameter #170
Conversation
The os.open() function got a new option keyword-only dir_fd parameter in Python 3.3: https://docs.python.org/3/library/os.html#os.open With this change, the open() now accepts the dir_fd parameter.
This comment has been minimized.
This comment has been minimized.
|
Thank you, it's merged in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vstinner commentedNov 27, 2014
The os.open() function got a new option keyword-only dir_fd parameter in
Python 3.3:
https://docs.python.org/3/library/os.html#os.open
With this change, the open() now accepts the dir_fd parameter.
For example, the dir_fd parameter is used by shutil.rmtree() for safety:
https://docs.python.org/3/library/shutil.html#shutil.rmtree
"Changed in version 3.3: Added a symlink attack resistant version that is used automatically if platform supports fd-based functions."