New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #274: Fix GreenSocket.recv_into() #275

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@vstinner
Contributor

vstinner commented Dec 16, 2015

Fix GreenSocket.recv_into(): if fd.recv_into() fails with a blocking I/O error: calls the trampoline in a loop, until the call succeed.

gh-274: Handle blocking I/O errors in GreenSocket
Fix recv_into(), recvfrom(), recvfrom_into() and sendto() methods of
GreenSocket to handle blocking I/O errors (ex: BlockingIOError on
Python 3). Even if the trampoline was called, the socket method can
still fails with an I/O errors for various reasons (see manual pages
of the C functions for examples).

Ref: #274
@vstinner

This comment has been minimized.

Show comment
Hide comment
@vstinner

vstinner Dec 17, 2015

Contributor

I completed my patch to fix the bug in more methods: "fix recv_into(), recvfrom(), recvfrom_into() and sendto() methods of GreenSocket to handle blocking I/O errors".

Contributor

vstinner commented Dec 17, 2015

I completed my patch to fix the bug in more methods: "fix recv_into(), recvfrom(), recvfrom_into() and sendto() methods of GreenSocket to handle blocking I/O errors".

@jstasiak

This comment has been minimized.

Show comment
Hide comment
@jstasiak

jstasiak Jan 7, 2016

Contributor

Thank you @haypo, just merged this into master (as 19035b1).

Contributor

jstasiak commented Jan 7, 2016

Thank you @haypo, just merged this into master (as 19035b1).

@jstasiak

This comment has been minimized.

Show comment
Hide comment
@jstasiak

jstasiak Jan 7, 2016

Contributor

I completely missed the fact that this breaks tests on Python 3, just reverted, sorry.

Contributor

jstasiak commented Jan 7, 2016

I completely missed the fact that this breaks tests on Python 3, just reverted, sorry.

@jstasiak jstasiak reopened this Jan 7, 2016

@jstasiak

This comment has been minimized.

Show comment
Hide comment
@jstasiak

jstasiak Jan 10, 2016

Contributor

A version produced in #274 has been merged into master (as bc4d1b5).

Contributor

jstasiak commented Jan 10, 2016

A version produced in #274 has been merged into master (as bc4d1b5).

@jstasiak jstasiak closed this Jan 10, 2016

@CyrilRoelandteNovance

This comment has been minimized.

Show comment
Hide comment
@CyrilRoelandteNovance

CyrilRoelandteNovance Jan 21, 2016

Do you think there could be a bugfix release of eventlet? I need this patch to fix a bug in OpenStack (https://bugs.launchpad.net/bugs/1521756).

Do you think there could be a bugfix release of eventlet? I need this patch to fix a bug in OpenStack (https://bugs.launchpad.net/bugs/1521756).

@jstasiak

This comment has been minimized.

Show comment
Hide comment
@jstasiak

jstasiak Jan 22, 2016

Contributor

I think I can update the change log by tomorrow (there are more changes than this, some of them breaking backwards compatibility) and then it's up to @temoto to upload it.

Contributor

jstasiak commented Jan 22, 2016

I think I can update the change log by tomorrow (there are more changes than this, some of them breaking backwards compatibility) and then it's up to @temoto to upload it.

@vstinner

This comment has been minimized.

Show comment
Hide comment
@vstinner

vstinner Jan 22, 2016

Contributor
Contributor

vstinner commented Jan 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment