Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't crash on PyPy 7.0.0 #547

Merged
merged 2 commits into from Oct 22, 2020
Merged

don't crash on PyPy 7.0.0 #547

merged 2 commits into from Oct 22, 2020

Conversation

@antocuni
Copy link
Contributor

@antocuni antocuni commented Feb 15, 2019

PyPy 7.0.0 uses 'py3-style' rlocks, i.e. they are implemented natively instead of being in pure-python. Fix commit fixes the code in the sense that at least doesn't crash on PyPy, but it still suffers of issue546, as python3.6 does

…hey are implemented natively instead of being in pure-python. Fix commit fixes the code in the sense that at least doesn't crash on PyPy, but it still suffers of issue546, as python3.6 does
@codecov-io
Copy link

@codecov-io codecov-io commented Feb 15, 2019

Codecov Report

No coverage uploaded for pull request base (master@a915bb6). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #547   +/-   ##
========================================
  Coverage          ?     44%           
========================================
  Files             ?      87           
  Lines             ?   11832           
  Branches          ?    1777           
========================================
  Hits              ?    5278           
  Misses            ?    6158           
  Partials          ?     396           
Flag Coverage Δ
#ipv6 16% <50%> (?)
#py27epolls 56% <50%> (?)
#py27poll 56% <50%> (?)
#py27selects 55% <50%> (?)
#py35epolls 49% <50%> (?)
#py35poll 49% <50%> (?)
#py35selects 49% <50%> (?)
#py36epolls 49% <50%> (?)
#py36poll 49% <50%> (?)
#py36selects 49% <50%> (?)
#py37epolls 49% <50%> (?)
#py37poll 49% <50%> (?)
#py37selects 49% <50%> (?)
#py38epolls 41% <50%> (?)
#py38poll 41% <50%> (?)
#py38selects 40% <50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
eventlet/patcher.py 32% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a915bb6...23aa74d. Read the comment docs.

@gordol
Copy link

@gordol gordol commented Jun 18, 2019

any chance this can be merged?

@gordol
Copy link

@gordol gordol commented Aug 7, 2019

we really need this for latest pypy support.

@temoto temoto requested review from tipabu and jstasiak Oct 21, 2020
temoto
temoto approved these changes Oct 21, 2020
Copy link
Member

@temoto temoto left a comment

LGTM

eventlet/patcher.py Outdated Show resolved Hide resolved
eventlet/patcher.py Outdated Show resolved Hide resolved
@temoto temoto merged commit 2f50526 into eventlet:master Oct 22, 2020
3 checks passed
bors bot added a commit to duckinator/parts.horse that referenced this issue Oct 24, 2020
68: Update eventlet to 0.29.1 r=duckinator a=pyup-bot


This PR updates [eventlet](https://pypi.org/project/eventlet) from **0.28.0** to **0.29.1**.



<details>
  <summary>Changelog</summary>
  
  
   ### 0.29.1
   ```
   ======
patcher: [py27] recursion error in pytest/python2.7 installing register_at_fork eventlet/eventlet#660
patcher: monkey_patch(builtins=True) failed on py3 because `file` class is gone eventlet/eventlet#541
don&#39;t crash on PyPy 7.0.0 eventlet/eventlet#547
Only install monotonic on python2 eventlet/eventlet#583
   ```
   
  
  
   ### 0.29.0
   ```
   ======
* ssl: context wrapped listener fails accept() eventlet/eventlet#651
   ```
   
  
  
   ### 0.28.1
   ```
   ======
* Sorry, Eventlet was broken on Windows for versions 0.27-0.28
  patcher: no os.register_at_fork on Windows (654)
* Clean up TypeError in __del__
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/eventlet
  - Changelog: https://pyup.io/changelogs/eventlet/
  - Homepage: http://eventlet.net
</details>



Co-authored-by: pyup-bot <github-bot@pyup.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants