Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend test cert to 2049 #643

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bmwiedemann
Copy link

This change makes tests pass in 2035 (also tested on i586)
Background:
As part of my work on reproducible builds for openSUSE, I check that software still gives identical build results in the future.
The usual offset is +15 years, because that is how long I expect some software will be used in some places.
This showed up failing tests in our package build.

See https://reproducible-builds.org/ for why this matters.

@codecov-commenter
Copy link

Codecov Report

Merging #643 into master will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #643   +/-   ##
======================================
- Coverage      44%     44%   -1%     
======================================
  Files          87      87           
  Lines       11813   11813           
  Branches     1773    1773           
======================================
- Hits         5269    5268    -1     
- Misses       6150    6151    +1     
  Partials      394     394           
Flag Coverage Δ
#ipv6 16% <ø> (ø)
#py27epolls ?
#py27poll 56% <ø> (-1%) ⬇️
#py27selects 55% <ø> (ø)
#py35epolls 49% <ø> (-1%) ⬇️
#py35poll 49% <ø> (ø)
#py35selects 49% <ø> (-1%) ⬇️
#py36epolls 49% <ø> (ø)
#py36poll 49% <ø> (ø)
#py36selects 49% <ø> (ø)
#py37epolls ?
#py37poll 49% <ø> (-1%) ⬇️
#py37selects 49% <ø> (-1%) ⬇️
#py38epolls ?
#py38poll 41% <ø> (-1%) ⬇️
#py38selects 40% <ø> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
eventlet/green/ssl.py 48% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44bfc1e...84e6539. Read the comment docs.

6 similar comments
@codecov-commenter
Copy link

Codecov Report

Merging #643 into master will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #643   +/-   ##
======================================
- Coverage      44%     44%   -1%     
======================================
  Files          87      87           
  Lines       11813   11813           
  Branches     1773    1773           
======================================
- Hits         5269    5268    -1     
- Misses       6150    6151    +1     
  Partials      394     394           
Flag Coverage Δ
#ipv6 16% <ø> (ø)
#py27epolls ?
#py27poll 56% <ø> (-1%) ⬇️
#py27selects 55% <ø> (ø)
#py35epolls 49% <ø> (-1%) ⬇️
#py35poll 49% <ø> (ø)
#py35selects 49% <ø> (-1%) ⬇️
#py36epolls 49% <ø> (ø)
#py36poll 49% <ø> (ø)
#py36selects 49% <ø> (ø)
#py37epolls ?
#py37poll 49% <ø> (-1%) ⬇️
#py37selects 49% <ø> (-1%) ⬇️
#py38epolls ?
#py38poll 41% <ø> (-1%) ⬇️
#py38selects 40% <ø> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
eventlet/green/ssl.py 48% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44bfc1e...84e6539. Read the comment docs.

@codecov-commenter
Copy link

Codecov Report

Merging #643 into master will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #643   +/-   ##
======================================
- Coverage      44%     44%   -1%     
======================================
  Files          87      87           
  Lines       11813   11813           
  Branches     1773    1773           
======================================
- Hits         5269    5268    -1     
- Misses       6150    6151    +1     
  Partials      394     394           
Flag Coverage Δ
#ipv6 16% <ø> (ø)
#py27epolls ?
#py27poll 56% <ø> (-1%) ⬇️
#py27selects 55% <ø> (ø)
#py35epolls 49% <ø> (-1%) ⬇️
#py35poll 49% <ø> (ø)
#py35selects 49% <ø> (-1%) ⬇️
#py36epolls 49% <ø> (ø)
#py36poll 49% <ø> (ø)
#py36selects 49% <ø> (ø)
#py37epolls ?
#py37poll 49% <ø> (-1%) ⬇️
#py37selects 49% <ø> (-1%) ⬇️
#py38epolls ?
#py38poll 41% <ø> (-1%) ⬇️
#py38selects 40% <ø> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
eventlet/green/ssl.py 48% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44bfc1e...84e6539. Read the comment docs.

@codecov-commenter
Copy link

Codecov Report

Merging #643 into master will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #643   +/-   ##
======================================
- Coverage      44%     44%   -1%     
======================================
  Files          87      87           
  Lines       11813   11813           
  Branches     1773    1773           
======================================
- Hits         5269    5268    -1     
- Misses       6150    6151    +1     
  Partials      394     394           
Flag Coverage Δ
#ipv6 16% <ø> (ø)
#py27epolls ?
#py27poll 56% <ø> (-1%) ⬇️
#py27selects 55% <ø> (ø)
#py35epolls 49% <ø> (-1%) ⬇️
#py35poll 49% <ø> (ø)
#py35selects 49% <ø> (-1%) ⬇️
#py36epolls 49% <ø> (ø)
#py36poll 49% <ø> (ø)
#py36selects 49% <ø> (ø)
#py37epolls ?
#py37poll 49% <ø> (-1%) ⬇️
#py37selects 49% <ø> (-1%) ⬇️
#py38epolls ?
#py38poll 41% <ø> (-1%) ⬇️
#py38selects 40% <ø> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
eventlet/green/ssl.py 48% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44bfc1e...84e6539. Read the comment docs.

@codecov-commenter
Copy link

Codecov Report

Merging #643 into master will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #643   +/-   ##
======================================
- Coverage      44%     44%   -1%     
======================================
  Files          87      87           
  Lines       11813   11813           
  Branches     1773    1773           
======================================
- Hits         5269    5268    -1     
- Misses       6150    6151    +1     
  Partials      394     394           
Flag Coverage Δ
#ipv6 16% <ø> (ø)
#py27epolls ?
#py27poll 56% <ø> (-1%) ⬇️
#py27selects 55% <ø> (ø)
#py35epolls 49% <ø> (-1%) ⬇️
#py35poll 49% <ø> (ø)
#py35selects 49% <ø> (-1%) ⬇️
#py36epolls 49% <ø> (ø)
#py36poll 49% <ø> (ø)
#py36selects 49% <ø> (ø)
#py37epolls ?
#py37poll 49% <ø> (-1%) ⬇️
#py37selects 49% <ø> (-1%) ⬇️
#py38epolls ?
#py38poll 41% <ø> (-1%) ⬇️
#py38selects 40% <ø> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
eventlet/green/ssl.py 48% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44bfc1e...84e6539. Read the comment docs.

@codecov-commenter
Copy link

Codecov Report

Merging #643 into master will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #643   +/-   ##
======================================
- Coverage      44%     44%   -1%     
======================================
  Files          87      87           
  Lines       11813   11813           
  Branches     1773    1773           
======================================
- Hits         5269    5268    -1     
- Misses       6150    6151    +1     
  Partials      394     394           
Flag Coverage Δ
#ipv6 16% <ø> (ø)
#py27epolls ?
#py27poll 56% <ø> (-1%) ⬇️
#py27selects 55% <ø> (ø)
#py35epolls 49% <ø> (-1%) ⬇️
#py35poll 49% <ø> (ø)
#py35selects 49% <ø> (-1%) ⬇️
#py36epolls 49% <ø> (ø)
#py36poll 49% <ø> (ø)
#py36selects 49% <ø> (ø)
#py37epolls ?
#py37poll 49% <ø> (-1%) ⬇️
#py37selects 49% <ø> (-1%) ⬇️
#py38epolls ?
#py38poll 41% <ø> (-1%) ⬇️
#py38selects 40% <ø> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
eventlet/green/ssl.py 48% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44bfc1e...84e6539. Read the comment docs.

@codecov-commenter
Copy link

Codecov Report

Merging #643 into master will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #643   +/-   ##
======================================
- Coverage      44%     44%   -1%     
======================================
  Files          87      87           
  Lines       11813   11813           
  Branches     1773    1773           
======================================
- Hits         5269    5268    -1     
- Misses       6150    6151    +1     
  Partials      394     394           
Flag Coverage Δ
#ipv6 16% <ø> (ø)
#py27epolls ?
#py27poll 56% <ø> (-1%) ⬇️
#py27selects 55% <ø> (ø)
#py35epolls 49% <ø> (-1%) ⬇️
#py35poll 49% <ø> (ø)
#py35selects 49% <ø> (-1%) ⬇️
#py36epolls 49% <ø> (ø)
#py36poll 49% <ø> (ø)
#py36selects 49% <ø> (ø)
#py37epolls ?
#py37poll 49% <ø> (-1%) ⬇️
#py37selects 49% <ø> (-1%) ⬇️
#py38epolls ?
#py38poll 41% <ø> (-1%) ⬇️
#py38selects 40% <ø> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
eventlet/green/ssl.py 48% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44bfc1e...84e6539. Read the comment docs.

This change makes tests pass after 2028
Background:
As part of my work on reproducible builds for openSUSE, I check that software still gives identical build results in the future.
The usual offset is +15 years, because that is how long I expect some software will be used in some places.
This showed up failing tests in our package build.

See https://reproducible-builds.org/ for why this matters.
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2020

Codecov Report

Merging #643 into master will increase coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #643   +/-   ##
======================================
  Coverage      44%     44%           
======================================
  Files          87      87           
  Lines       11831   11831           
  Branches     1774    1774           
======================================
+ Hits         5254    5266   +12     
+ Misses       6180    6171    -9     
+ Partials      397     394    -3     
Flag Coverage Δ
#ipv6 16% <ø> (?)
#py27epolls 56% <ø> (+<1%) ⬆️
#py27poll 56% <ø> (+<1%) ⬆️
#py35epolls 49% <ø> (ø)
#py35poll 49% <ø> (-1%) ⬇️
#py35selects 49% <ø> (?)
#py36epolls 49% <ø> (ø)
#py36poll 49% <ø> (+<1%) ⬆️
#py36selects 49% <ø> (ø)
#py37epolls 49% <ø> (ø)
#py37poll 49% <ø> (+<1%) ⬆️
#py37selects ?
#py38epolls 41% <ø> (-1%) ⬇️
#py38poll ?
#py38selects 40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
eventlet/wsgi.py 70% <0%> (+<1%) ⬆️
eventlet/hubs/__init__.py 70% <0%> (+3%) ⬆️
eventlet/backdoor.py 94% <0%> (+6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 004cc4e...df6b965. Read the comment docs.

@temoto
Copy link
Member

temoto commented Oct 18, 2020

@bmwiedemann nice job. Do you want to copy this script to automate creating new short lived certificates?

https://github.com/httplib2/httplib2/blob/master/script/generate-tls

@bmwiedemann
Copy link
Author

@bmwiedemann nice job. Do you want to copy this script to automate creating new short lived certificates?

https://github.com/httplib2/httplib2/blob/master/script/generate-tls

That would also work. Could you do it? I can test patches.

@temoto
Copy link
Member

temoto commented Dec 15, 2020

This issue is resolved when we don't have fixed certificates in repo.

Sorry, date comparison in 2028 is last priority for me right now.

@bmwiedemann
Copy link
Author

It is actually already failing in 2028

openssl x509 -text -in tests/test_server.crt
Not After : Aug 19 13:42:11 2028 GMT

@temoto
Copy link
Member

temoto commented Dec 15, 2020

fixed for 28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants