New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend test cert to 2049 #643
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #643 +/- ##
======================================
- Coverage 44% 44% -1%
======================================
Files 87 87
Lines 11813 11813
Branches 1773 1773
======================================
- Hits 5269 5268 -1
- Misses 6150 6151 +1
Partials 394 394
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
6 similar comments
Codecov Report
@@ Coverage Diff @@
## master #643 +/- ##
======================================
- Coverage 44% 44% -1%
======================================
Files 87 87
Lines 11813 11813
Branches 1773 1773
======================================
- Hits 5269 5268 -1
- Misses 6150 6151 +1
Partials 394 394
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #643 +/- ##
======================================
- Coverage 44% 44% -1%
======================================
Files 87 87
Lines 11813 11813
Branches 1773 1773
======================================
- Hits 5269 5268 -1
- Misses 6150 6151 +1
Partials 394 394
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #643 +/- ##
======================================
- Coverage 44% 44% -1%
======================================
Files 87 87
Lines 11813 11813
Branches 1773 1773
======================================
- Hits 5269 5268 -1
- Misses 6150 6151 +1
Partials 394 394
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #643 +/- ##
======================================
- Coverage 44% 44% -1%
======================================
Files 87 87
Lines 11813 11813
Branches 1773 1773
======================================
- Hits 5269 5268 -1
- Misses 6150 6151 +1
Partials 394 394
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #643 +/- ##
======================================
- Coverage 44% 44% -1%
======================================
Files 87 87
Lines 11813 11813
Branches 1773 1773
======================================
- Hits 5269 5268 -1
- Misses 6150 6151 +1
Partials 394 394
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #643 +/- ##
======================================
- Coverage 44% 44% -1%
======================================
Files 87 87
Lines 11813 11813
Branches 1773 1773
======================================
- Hits 5269 5268 -1
- Misses 6150 6151 +1
Partials 394 394
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This change makes tests pass after 2028 Background: As part of my work on reproducible builds for openSUSE, I check that software still gives identical build results in the future. The usual offset is +15 years, because that is how long I expect some software will be used in some places. This showed up failing tests in our package build. See https://reproducible-builds.org/ for why this matters.
Codecov Report
@@ Coverage Diff @@
## master #643 +/- ##
======================================
Coverage 44% 44%
======================================
Files 87 87
Lines 11831 11831
Branches 1774 1774
======================================
+ Hits 5254 5266 +12
+ Misses 6180 6171 -9
+ Partials 397 394 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@bmwiedemann nice job. Do you want to copy this script to automate creating new short lived certificates? https://github.com/httplib2/httplib2/blob/master/script/generate-tls |
That would also work. Could you do it? I can test patches. |
|
This issue is resolved when we don't have fixed certificates in repo. Sorry, date comparison in 2028 is last priority for me right now. |
|
It is actually already failing in 2028 |
|
fixed for 28 |
This change makes tests pass in 2035 (also tested on i586)
Background:
As part of my work on reproducible builds for openSUSE, I check that software still gives identical build results in the future.
The usual offset is +15 years, because that is how long I expect some software will be used in some places.
This showed up failing tests in our package build.
See https://reproducible-builds.org/ for why this matters.