Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patcher: no os.register_at_fork on Windows #654

Merged
merged 1 commit into from Oct 19, 2020
Merged

patcher: no os.register_at_fork on Windows #654

merged 1 commit into from Oct 19, 2020

Conversation

@temoto
Copy link
Member

@temoto temoto commented Oct 17, 2020

#644

Eventlet 0.27.0 and 0.28.0 were incompatible with Windows (and other non-Unix) platforms

#644

Eventlet 0.27.0 and 0.28.0 were incompatible with Windows (and other non-Unix) platforms
@temoto temoto requested a review from tipabu Oct 17, 2020
tipabu
tipabu approved these changes Oct 19, 2020
Copy link
Contributor

@tipabu tipabu left a comment

Looks entirely reasonable, and I remember thinking at the time that I should maybe do a hasattr check. Sorry for the breakage.

@tipabu tipabu merged commit f227ef6 into master Oct 19, 2020
2 checks passed
@tipabu tipabu deleted the i644 branch Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants