Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several issues with python3 thread patching #99

Closed
wants to merge 1 commit into from

Conversation

@therve
Copy link

therve commented Jul 3, 2014

I found a bunch of issues testing eventlet and python3 regarding threading. This patch solves some of them.

@temoto

This comment has been minimized.

Copy link
Member

temoto commented Jul 3, 2014

Hello, @therve

Thanks for your patch.

Could you describe how to reproduce your issues? Ideally, we'd add unit tests.

@therve

This comment has been minimized.

Copy link
Author

therve commented Jul 3, 2014

Hi,

Yeah I'll try to provide more tests, but they are tricky to write, as they are mostly related to monkey patching.

@temoto temoto closed this Jul 10, 2014
@vstinner

This comment has been minimized.

Copy link
Contributor

vstinner commented Jul 10, 2014

@temoto: Why did you close the pull request?

@temoto

This comment has been minimized.

Copy link
Member

temoto commented Jul 10, 2014

I think it closed automatically as I deleted py3-greenio branch.

Your work will not be lost.

@shivaenigma shivaenigma mentioned this pull request Oct 30, 2014
@temoto

This comment has been minimized.

Copy link
Member

temoto commented Nov 23, 2014

We can't always assign main_thread in module top level code because there's no guarantee this module was first imported from main thread. Otherwise, your patch was merged by @jstasiak in 23beb7d

Thanks for contribution.

@vstinner

This comment has been minimized.

Copy link
Contributor

vstinner commented Nov 24, 2014

We can't always assign main_thread in module top level code because there's no guarantee this module was first imported from main thread.

I agree and I don't like this change. Maybe my pull request is enough to fix this point?
#168

@temoto

This comment has been minimized.

Copy link
Member

temoto commented Nov 24, 2014

@Haypo maybe. I'll look at your patcher test tomorrow to understand what it fixes. Thanks for pushing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.