Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

EM::Protocols::Postgres3, readbytes and Ruby 1.9 #167

Closed
martinkozak opened this Issue Feb 8, 2011 · 1 comment

Comments

Projects
None yet
3 participants

The em/protocols/postgres3.rb requires the "readbytes" (line 27), but it isn't available in Ruby 1.9. It seems, it works well without readbytes because it doesn't use it nowhere (because it's monkey patched, of sure).

Result is, Postgres3 implementation is unusable in Ruby 1.9 (at least in Ruby 1.9.2p136) without patching or another problematic circumventions of the EventMachine library requires.

jtoy commented Aug 19, 2011

There is a patch that addresses this, but its not in trunk yet.

@tmm1 tmm1 closed this in a30944a Sep 9, 2011

@pbozeman pbozeman pushed a commit to pbozeman/eventmachine that referenced this issue Oct 26, 2011

@raggi raggi Merge branch 'master' into close_schedule_fix
* master: (146 commits)
  Fix reconnect on unix-domain connection #261
  Fix rake-compiler cross compiling issues for win32 gems
  Another compile warning
  Fix compile warning
  README grammar fix
  bump rake-compiler dependency
  Remove dependency on readbytes.rb for ruby 1.9 (fixes #167, #234)
  Fix compilation on MSVC2008 (fixes #253)
  fix code samples in iterator docs
  pull pause/resume logic down into EventableDescriptor
  test EM::Connection#pause on popen connections
  print out ssl errors to stdout before exploding
  Renaming EventMachine_t Closing to Deregister
  Watched sockets should still receive Closing
  Tweaking the patch to only affect socket shutdown and close. Ref: #242
  Alias Ruby C API methods for 1.8/1.9 compat
  Add pure-ruby implementations of EM::Connection#set_sock_opt and #get_sock_opt
  Implement EM::Connection#set_sock_opt
  Never close STDIN, STDOUT and STDERR (i.e. only close when fd > 2) Should solve #183
  Segfault fix for pipes
  ...

Conflicts:
	ext/em.cpp
	tests/test_basic.rb
2cd0c19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment