Added a Null Object in jeventmachine to prevent exceptions #124

Open
wants to merge 8 commits into
from

4 participants

@dougbradbury

Before eventmachine is initialized or after it's been release, I put in place a Null Object that will prevent "undefined method for nil" errors. This is a fix for issue 123.

@dougbradbury

Why has this never been touched? Any comments?

@ibc

Because EventMachine is unmantained. See #329 (comment).

@garbagecat
@ibc

Hi @garbagecat, Carsten Bormann and me forked the project into EventMachine-LE which includes various ignored pull requests and bug fixes (i.e. real and tested IPv6 support for UDP and TCP client/server). Please consider taking a look to it.

Thanks a lot.

@garbagecat
@dougbradbury

@ibc It look like you guys dumped the java reactor though? That's too bad.

@ibc
ibc commented Sep 1, 2012

You are right, but the EM Java version was really outdated and does not include lot of changes, features and improvements in the C++ reactor.

@m0wfo

@ibc , I'm trying to clear up a few of the JRuby issues in this repo, maybe It'd be better to add the changes to yours though?

@ibc

Hi @m0wfo, eventmachine-le has no Java reactor, it was removed because it was considered not updated to the C version.

@m0wfo

@ibc Appreciate that- the Java version needs some love. I'm rewriting the original in pure ruby so I'll check back when I have something more concrete.

@sodabrew sodabrew added a commit to sodabrew/eventmachine that referenced this pull request Feb 2, 2015
Doug Bradbury Abstract out an EmReactorInterface and create a NullEmReactor and
NullEventableChannel to use when the reactor should not be running.

This is a rebase of PR #124.
bf1eac8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment