Correctly pass error to `unbind` on connection handler #289

Merged
merged 1 commit into from Jan 16, 2012

Conversation

Projects
None yet
4 participants
Contributor

mislav commented Jan 15, 2012

To check if a method accepts at least 1 argument, it's better to check arity != 0. Checking arity == 1 is wrong since the first argument may be optional, in which case arity will be -1.

Contributor

ibc commented Jan 15, 2012

This pull request should be included in EM master ASAP. Thanks a lot.

tmm1 added a commit that referenced this pull request Jan 16, 2012

Merge pull request #289 from mislav/unbind
Correctly pass error to `unbind` on connection handler

@tmm1 tmm1 merged commit 64a949a into eventmachine:master Jan 16, 2012

avsej commented Mar 22, 2012

+1, when will be next EM release?

Contributor

ibc commented Mar 22, 2012

Probably never. But you can check EventMachine-LE which already includes that patch in the stable 1.1.0 Gem version (along with other pull requests):

https://github.com/ibc/EventMachine-LE/

avsej commented Mar 22, 2012

Thanks @ibc

@mislav mislav deleted the mislav:unbind branch Feb 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment