Added windows IPv6 support #303

Closed
wants to merge 13 commits into
from

Conversation

Projects
None yet
5 participants
@stakach

stakach commented Mar 6, 2012

Also increased file and socket limits

@stakach

This comment has been minimized.

Show comment Hide comment
@stakach

stakach Mar 7, 2012

@tmm1 just thought I'd let you know that I've completely solved the issues with connection weirdness and eventmachine on windows.

The FD_SETSIZE must be the same on ruby installer as it is in eventmachine.
The next release of ruby installer will increase the limit to 32767 so this must be reflected in project.h
Previous versions of ruby installer ruby will continue to work as they used to.

Thanks for your on going help in the matter. Very much appreciated and helpful.
I'll also stop harassing you now too. ;)

stakach commented Mar 7, 2012

@tmm1 just thought I'd let you know that I've completely solved the issues with connection weirdness and eventmachine on windows.

The FD_SETSIZE must be the same on ruby installer as it is in eventmachine.
The next release of ruby installer will increase the limit to 32767 so this must be reflected in project.h
Previous versions of ruby installer ruby will continue to work as they used to.

Thanks for your on going help in the matter. Very much appreciated and helpful.
I'll also stop harassing you now too. ;)

@stakach stakach referenced this pull request in oneclick/rubyinstaller Mar 7, 2012

Closed

Low socket limit #104

@stakach

This comment has been minimized.

Show comment Hide comment
@stakach

stakach Mar 7, 2012

The ruby installer issue oneclick/rubyinstaller#104

stakach commented Mar 7, 2012

The ruby installer issue oneclick/rubyinstaller#104

@stakach

This comment has been minimized.

Show comment Hide comment
@stakach

stakach Mar 8, 2012

@tmm1 the final product rolled out at Sydney University running on eventmachine and rubyinstaller ruby.
I did a little write up on the project.

https://groups.google.com/forum/?fromgroups#!topic/rubyinstaller/0UlbSlwXa6U

stakach commented Mar 8, 2012

@tmm1 the final product rolled out at Sydney University running on eventmachine and rubyinstaller ruby.
I did a little write up on the project.

https://groups.google.com/forum/?fromgroups#!topic/rubyinstaller/0UlbSlwXa6U

@stakach stakach referenced this pull request in rubinius/rubinius Mar 8, 2012

Closed

Eventmachine Support on Windows #1600

@rdp

This comment has been minimized.

Show comment Hide comment
@rdp

rdp Mar 8, 2012

why does it have to match the rubyinstaller FD_SETSIZE again?

rdp commented Mar 8, 2012

why does it have to match the rubyinstaller FD_SETSIZE again?

@stakach

This comment has been minimized.

Show comment Hide comment
@stakach

stakach Mar 8, 2012

From observations on Windows 2008 R2 x64 VM

  1. Ruby SETSIZE < EM SETSIZE
  • Ruby SETSIZE is enforced
  • Unpredictable behaviour beyond Ruby SETSIZE (at one point I had sockets surviving program termination that remained ESTABLISHED)
    1. Ruby SETSIZE > EM SETSIZE
  • segfault

stakach commented Mar 8, 2012

From observations on Windows 2008 R2 x64 VM

  1. Ruby SETSIZE < EM SETSIZE
  • Ruby SETSIZE is enforced
  • Unpredictable behaviour beyond Ruby SETSIZE (at one point I had sockets surviving program termination that remained ESTABLISHED)
    1. Ruby SETSIZE > EM SETSIZE
  • segfault
@rdp

This comment has been minimized.

Show comment Hide comment
@rdp

rdp Mar 22, 2012

actually ruby's extconf system will automagically set this to the higher number for you already, won't it? (i.e. you don't have to set it at all?)

rdp commented on 9839573 Mar 22, 2012

actually ruby's extconf system will automagically set this to the higher number for you already, won't it? (i.e. you don't have to set it at all?)

This comment has been minimized.

Show comment Hide comment
@stakach

stakach Mar 22, 2012

Owner

Maybe.
I assume you would have to set it here too as it is compiled independently from ruby then loaded dynamically at run time.

Owner

stakach replied Mar 22, 2012

Maybe.
I assume you would have to set it here too as it is compiled independently from ruby then loaded dynamically at run time.

This comment has been minimized.

Show comment Hide comment
@rdp

rdp Mar 22, 2012

I believe when ruby calls gcc it passes in the "original parameters ruby itself was built with" which includes the -DFD_SETSIZE config.

rdp replied Mar 22, 2012

I believe when ruby calls gcc it passes in the "original parameters ruby itself was built with" which includes the -DFD_SETSIZE config.

This comment has been minimized.

Show comment Hide comment
@stakach

stakach Mar 22, 2012

Owner

Sweet!
Ill do a test compile this afternoon and update the pull request.

Owner

stakach replied Mar 22, 2012

Sweet!
Ill do a test compile this afternoon and update the pull request.

This comment has been minimized.

Show comment Hide comment
@stakach

stakach Mar 26, 2012

Owner

Wait, we should leave it here as other projects such as http://rubini.us/ will not be including the flag.
See rubinius/rubinius#1600

Owner

stakach replied Mar 26, 2012

Wait, we should leave it here as other projects such as http://rubini.us/ will not be including the flag.
See rubinius/rubinius#1600

This comment has been minimized.

Show comment Hide comment
@rdp

rdp Mar 26, 2012

If other projects don't include it then it should fall back to the default shouldn't it? (otherwise you'll see the descrepancies you noted)?

rdp replied Mar 26, 2012

If other projects don't include it then it should fall back to the default shouldn't it? (otherwise you'll see the descrepancies you noted)?

This comment has been minimized.

Show comment Hide comment
@stakach

stakach Mar 27, 2012

Owner

True that. I'll remove now and update the rubinius issue

Owner

stakach replied Mar 27, 2012

True that. I'll remove now and update the rubinius issue

This comment has been minimized.

Show comment Hide comment
@stakach

stakach Mar 27, 2012

Owner

See: 8840d22

Owner

stakach replied Mar 27, 2012

See: 8840d22

@alor

This comment has been minimized.

Show comment Hide comment
@alor

alor Apr 24, 2012

have you tested it with rubyinstaller 1.9.3-p194 ?
i'm having some problems with it... see #319.

alor commented Apr 24, 2012

have you tested it with rubyinstaller 1.9.3-p194 ?
i'm having some problems with it... see #319.

@Azolo

This comment has been minimized.

Show comment Hide comment
@Azolo

Azolo May 10, 2012

@stakach Since 8840d22 solves #319 and could be considered a fix this is beyond the scope of just this PR think you could extract it into a new one?

Azolo commented May 10, 2012

@stakach Since 8840d22 solves #319 and could be considered a fix this is beyond the scope of just this PR think you could extract it into a new one?

@stakach

This comment has been minimized.

Show comment Hide comment
@stakach

stakach May 10, 2012

Well the aim of this pull request was to improve windows support on eventmachine.

@tmm1 is there any reason we can't merge these changes and create a new windows release?

stakach commented May 10, 2012

Well the aim of this pull request was to improve windows support on eventmachine.

@tmm1 is there any reason we can't merge these changes and create a new windows release?

@stakach

This comment has been minimized.

Show comment Hide comment
@stakach

stakach May 10, 2012

@raggi maybe you could help?

stakach commented May 10, 2012

@raggi maybe you could help?

@sodabrew

This comment has been minimized.

Show comment Hide comment
@sodabrew

sodabrew Jan 29, 2015

Contributor

Note to self: Check if #570 includes this work.

Contributor

sodabrew commented Jan 29, 2015

Note to self: Check if #570 includes this work.

@sodabrew sodabrew added this to the v1.2.0 milestone Aug 11, 2015

@sodabrew

This comment has been minimized.

Show comment Hide comment
@sodabrew

sodabrew Aug 21, 2015

Contributor

Superseded by #630

Contributor

sodabrew commented Aug 21, 2015

Superseded by #630

@sodabrew sodabrew closed this Aug 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment