Adjust number of file descriptors for Windows #337

Merged
merged 1 commit into from Jun 26, 2012

Conversation

Projects
None yet
2 participants
Contributor

luislavena commented Jun 21, 2012

Define FD_SETSIZE unless it is already present in Ruby configuration.

This works around FD_SETSIZE not defined in some releases of
RubyInstaller and solve the segfault caused by mismatch value between
Ruby and the extension.

This solves #333 and #319

Thank you ❤️ ❤️ ❤️

@luislavena luislavena Adjust number of file descriptors for Windows
Define `FD_SETSIZE` unless it is already present in Ruby configuration.

This works around `FD_SETSIZE` not defined in some releases of
RubyInstaller and solve the segfault caused by mismatch value between
Ruby and the extension.
842bbe4
Contributor

luislavena commented Jun 25, 2012

@tmm1 @raggi ping? as commented in #333, here is the pull request with the FD_SETSIZE changes.

Let me know if there is something else I need to do.

Thank you.

Contributor

tmm1 commented Jun 26, 2012

Thanks @luislavena. Merging and will push out a rc2 gem.

@tmm1 tmm1 added a commit that referenced this pull request Jun 26, 2012

@tmm1 tmm1 Merge pull request #337 from luislavena/adjust-fd-setsize-for-windows
Adjust number of file descriptors for Windows
0f15075

@tmm1 tmm1 merged commit 0f15075 into eventmachine:master Jun 26, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment