Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Travis-CI support and a slight change to the rake task #381

Merged
merged 4 commits into from

4 participants

@razielgn

Hi eventmachine maintainers,
I'm submitting this pull request with added Travis-CI support to ensure every commit is run against rubinius (this is part of a global effort, see rubinius/rubinius#2006).
I had to slightly change the rake task regarding the packaging, so to get compatibility with newer environments (while retaining old compatibility, see https://travis-ci.org/razielgn/eventmachine).
At the moment, rubinius hangs on �test_fork_safe� and fails in a couple other, so test runs against it are marked as "allow failure".
Please, once merged enable support from Travis-Ci (https://travis-ci.org) on your repository.
Thanks.

@ttilley

I have yet to see all of the tests pass on any revision of EventMachine on any implementation of ruby. Personally, I'm more interested in figuring out why rubinius hangs indefinitely on test_fork_safe. Just my not-entirely-helpful 0.02.

@jc00ke

@ttilley so are we. This PR will help the Rubinius team track issues like this across a bunch of different gems with C-extensions.

@tmm1 tmm1 merged commit 1aeb8a9 into eventmachine:master

1 check passed

Details default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 13, 2012
  1. @razielgn
  2. @razielgn

    Added Travis-CI support.

    razielgn authored
Commits on Nov 14, 2012
  1. @jc00ke

    Allow rbx to fail

    jc00ke authored
  2. @razielgn

    Merge pull request #1 from jc00ke/patch-1

    razielgn authored
    Allow rbx to fail
This page is out of date. Refresh to see the latest.
Showing with 21 additions and 2 deletions.
  1. +12 −0 .travis.yml
  2. +9 −2 rakelib/package.rake
View
12 .travis.yml
@@ -0,0 +1,12 @@
+script: rake compile test
+language: ruby
+rvm:
+ - 1.8.7
+ - 1.9.3
+ - rbx-18mode
+ - rbx-19mode
+ - jruby
+matrix:
+ allow_failures:
+ - rvm: rbx-18mode
+ - rvm: rbx-19mode
View
11 rakelib/package.rake
@@ -1,4 +1,11 @@
-require 'rake/gempackagetask'
+begin
+ require 'rubygems'
+ require 'rubygems/package_task'
+rescue LoadError
+ require 'rake/packagetask'
+ require 'rake/gempackagetask'
+end
+
begin
require 'rake/extensiontask'
require 'rake/javaextensiontask'
@@ -12,7 +19,7 @@ rake-compiler gem seems to be missing. Please install it with
MSG
end
-Rake::GemPackageTask.new(GEMSPEC) do |pkg|
+Rake::PackageTask.new(GEMSPEC, EventMachine::VERSION) do |pkg|
end
if RUBY_PLATFORM =~ /java/
Something went wrong with that request. Please try again.