Fix crash on attach/detach in the same tick #427

Merged
merged 1 commit into from Mar 26, 2013

Conversation

Projects
None yet
3 participants
@pietern
Contributor

pietern commented Mar 25, 2013

Remove descriptor from NewDescriptors when it is detached to fix this issue.

@pietern

This comment has been minimized.

Show comment Hide comment
@pietern

pietern Mar 25, 2013

Contributor

Please hold off on merging this; it seems to introduce a failure in tests/test_idle_connection.rb.

Contributor

pietern commented Mar 25, 2013

Please hold off on merging this; it seems to introduce a failure in tests/test_idle_connection.rb.

@pietern

This comment has been minimized.

Show comment Hide comment
@pietern

pietern Mar 25, 2013

Contributor

It only fails when EM.epoll is set, regardless of this patch being applied or not.

Contributor

pietern commented Mar 25, 2013

It only fails when EM.epoll is set, regardless of this patch being applied or not.

tmm1 added a commit that referenced this pull request Mar 26, 2013

Merge pull request #427 from pietern/attach-detach
Fix crash on attach/detach in the same tick

@tmm1 tmm1 merged commit 7f5e231 into eventmachine:master Mar 26, 2013

@ibc

This comment has been minimized.

Show comment Hide comment
@ibc

ibc Apr 2, 2013

Contributor

It seems that this patch makes the test_idle_time(TestIdleConnection) to fail:

<0> expected but was
<3.044585943222046>
Contributor

ibc commented Apr 2, 2013

It seems that this patch makes the test_idle_time(TestIdleConnection) to fail:

<0> expected but was
<3.044585943222046>

tmm1 added a commit that referenced this pull request Apr 2, 2013

@ibc

This comment has been minimized.

Show comment Hide comment
@ibc

ibc Apr 2, 2013

Contributor

Works :)

Contributor

ibc commented Apr 2, 2013

Works :)

@pietern pietern deleted the pietern:attach-detach branch Jul 13, 2013

sodabrew pushed a commit to sodabrew/eventmachine that referenced this pull request Jan 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment