Fix crash on attach/detach in the same tick #427

Merged
merged 1 commit into from Mar 26, 2013

Projects

None yet

3 participants

@pietern

Remove descriptor from NewDescriptors when it is detached to fix this issue.

@pietern

Please hold off on merging this; it seems to introduce a failure in tests/test_idle_connection.rb.

@pietern

It only fails when EM.epoll is set, regardless of this patch being applied or not.

@tmm1 tmm1 merged commit 7f5e231 into eventmachine:master Mar 26, 2013
@ibc
ibc commented Apr 2, 2013

It seems that this patch makes the test_idle_time(TestIdleConnection) to fail:

<0> expected but was
<3.044585943222046>
@tmm1 tmm1 added a commit that referenced this pull request Apr 2, 2013
@tmm1 tmm1 fix idle test with epoll (cc #427) 61095b4
@ibc
ibc commented Apr 2, 2013

Works :)

@pietern pietern deleted the unknown repository branch Jul 13, 2013
@sodabrew sodabrew pushed a commit to sodabrew/eventmachine that referenced this pull request Jan 27, 2015
@ibc ibc Fix crash on attach/detach in the same tick (eventmachine#427). c9a6ba5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment