Remove most unit test dependencies on third-party sites #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodabrew
force-pushed
the
local_tests
branch
2 times, most recently
from
1c4fd0d
to
dd35bbf
Compare
sodabrew
force-pushed
the
local_tests
branch
from
dd35bbf
to
fc62e3b
Compare
But there isn't a public DNS record like 'example.com' with an A rrset, so we'll continue to use yahoo.com for that.
sodabrew
force-pushed
the
local_tests
branch
2 times, most recently
from
b04dbbe
to
6d5e958
Compare
sodabrew
changed the title
sodabrew
force-pushed
the
local_tests
branch
from
6d5e958
to
849e985
Compare
* Minor syntax updates, avoid trailing semicolons * Close connections to avoid hanging on keep-alive HTTP * Use next_port helper instead of hardcoded port numbers
* Add EM timeouts * Use HTTP/1.0 to prevent connection keep-alives * Use next_port helper instead of hardcoded port number
sodabrew
force-pushed
the
local_tests
branch
from
849e985
to
5d17b61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally deflake the CI runs while we're at it.