Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop events processing when disconnected #2

Merged
merged 3 commits into from May 2, 2018

Conversation

Projects
None yet
1 participant
@glensc
Copy link
Member

commented May 1, 2018

avoid processing events if bot is not in destined channels

either bot is disconnected or kicked out of channel.

@glensc

This comment has been minimized.

Copy link
Member Author

commented May 1, 2018

also asked for some feedback in smartirc bugtracker: https://pear.php.net/bugs/bug.php?id=23746

@glensc glensc force-pushed the disconnected-events branch from a3b061a to d16b481 May 1, 2018

glensc added some commits May 1, 2018

avoid processing events if bot is not in destined channels
either bot is disconnected or kicked out of channel.
project: filter known keys
this is to avoid blown up if xmlrpc will return more data in the future

@glensc glensc force-pushed the disconnected-events branch from d16b481 to 29acfb1 May 2, 2018

@glensc glensc changed the base branch from mvp to master May 2, 2018

@glensc glensc changed the title WIP: Events processing when disconnected Stop events processing when disconnected May 2, 2018

@glensc glensc force-pushed the disconnected-events branch from d189f87 to 3e7cf2d May 2, 2018

@glensc glensc merged commit 236ec91 into master May 2, 2018

@glensc glensc deleted the disconnected-events branch May 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.