Skip to content

Upgrade dependecies 2 - #216

Merged
evereq merged 14 commits into
developfrom
upgrade-dependecies-2
May 22, 2021
Merged

Upgrade dependecies 2#216
evereq merged 14 commits into
developfrom
upgrade-dependecies-2

Conversation

@rahul-rocket

Copy link
Copy Markdown
Collaborator

Before submitting the PR, please make sure you do the following

  1. Contributor license agreement
    For us it's important to have the agreement of our contributors to use their work, whether it be code or documentation. Therefore, we are asking all contributors to sign a contributor license agreement (CLA) as commonly accepted in most open source projects. Just open the pull request and our CLA bot will prompt you briefly.

  2. Please check our contribution guidelines for some help in the process.

@CLAassistant

CLAassistant commented May 12, 2021

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@rahul-rocket

Copy link
Copy Markdown
Collaborator Author

@evereq

Hi,
I have upgraded webapp (Angualar) and api (NestJs) application to latest version.

Bumps NestJs from 6.5.3 to 7.6.15.
Bumps Angular from 9.1.0 to 11.2.13.

Please let me know if you want any changes from my side.
Thank you!

Comment thread api/src/main.ts
Comment thread api/src/formatters/yaml-nested.ts
Comment thread webapp/angular.json
Comment thread webapp/src/polyfills.ts Outdated
Comment thread webapp/src/tsconfig.app.json Outdated
Comment thread api/src/config.ts Outdated
@evereq

evereq commented May 17, 2021

Copy link
Copy Markdown
Member

@rahul-rathore-576 please check 2 failing tests and try to fix that, see more details below (from our Slack)

We have 2 tests failing https://app.circleci.com/pipelines/github/ever-co/ever-traduora/463/workflows/40959840-10e4-4269-b156-c0c43551d307/jobs/515
The reason they are failing is unknown to me, i.e. not sure why.
But from what I see it takes json from simple-nested.json file

"term:four": "hello there you\\nthis should be in a newline"

(simple-nested.yaml)

and try to compare it to what it should be in yaml file (simple-nested.yaml)

'term:four': hello there you\nthis should be in a newline

and somehow it fails
because it produces the wrong YAML from what I understand
i.e. it produce

term:four: hello there you\nthis should be in a newline

and you can see no ' symbol around the key value
i.e. should be 'term:four', but we get term:four.
(no ' symbol)

So we need to figure out why that happens and fix code the way that this test pass
😉

Btw, think you can run tests manually with
yarn test && yarn test:e2e

@rahul-rocket
rahul-rocket force-pushed the upgrade-dependecies-2 branch from b383cd1 to 0b7f96d Compare May 18, 2021 16:02
@evereq
evereq marked this pull request as ready for review May 22, 2021 17:28
@evereq
evereq merged commit 07805bd into develop May 22, 2021
@evereq
evereq deleted the upgrade-dependecies-2 branch May 22, 2021 17:29
@evereq

evereq commented May 22, 2021

Copy link
Copy Markdown
Member

PR merged. Issue with tests was before all updates in this PR, so it will be fixed in some other branch / PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants