Skip to content

Fix/#CSV Injection Vulnerability Fixes - #289

Merged
evereq merged 29 commits into
developfrom
fix-csv-injection
Jan 29, 2022
Merged

evereq merged 29 commits into
developfrom
fix-csv-injection

Conversation

@bvenceslas

@bvenceslas bvenceslas commented Jan 26, 2022 •

Copy link
Copy Markdown
Contributor

@vercel

vercel Bot commented Jan 26, 2022

Copy link
Copy Markdown

Deployment failed with the following error:

The most recent charge for your active payment method has failed. Please update it here: https://vercel.com/teams/ever-co/settings/billing.

@bvenceslas bvenceslas changed the title fixed the csv injection vulnerability fix/#csv-injection-vulnerability fixed- Jan 26, 2022
@rahul-rocket rahul-rocket changed the title fix/#csv-injection-vulnerability fixed- Fix/#CSV Injection Vulnerability Fixes Jan 26, 2022
Comment thread api/package.json Resolved
Comment thread api/src/formatters/csv.ts Resolved
Comment thread api/src/formatters/csv.ts Resolved
Comment thread api/src/formatters/csv.ts Resolved
Comment thread api/src/config.ts Resolved
@evereq
evereq merged commit 3fcde55 into develop Jan 29, 2022
@evereq
evereq deleted the fix-csv-injection branch January 29, 2022 18:47
evereq added a commit that referenced this pull request Jan 29, 2022
* fixed the csv injection vulnerability

* fix: remove default password

* refactored the logic

* added some risky characters to escape

* removed the console.log

* fix the deepscan warning

* fix: api/package.json & api/yarn.lock to reduce vulnerabilities

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-SWAGGERUIDIST-2314884

* build(deps): bump node-fetch from 2.6.2 to 2.6.7 in /api

Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.2 to 2.6.7.
- [Release notes](https://github.com/node-fetch/node-fetch/releases)
- [Commits](node-fetch/node-fetch@v2.6.2...v2.6.7)

---
updated-dependencies:
- dependency-name: node-fetch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* fixed conflicts from package.json
:wq

* refactored the logic

* fixed conflict

* removed the console.log

* added some comments on the refactored code

* added test for the cleaning risky characters

* fix: increased default jest timeout

* fix: deepscan & increased jest timeout

* fix: formatting with prettier

* fix: csv injection matching with first character of csv cell

* fix: formatting using Prettier

* fix: deepscan

* feat: split unit and e2e tests as separate jobs

* fix: ops

* feat: update Circle to use Orbs

* fix: run tests in feature branches too

* fix: scripts permissions

Co-authored-by: RAHUL RATHORE <rahulrathore576@gmail.com>
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Co-authored-by: Ruslan Konviser <evereq@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants