Skip to content

Invite system - #66

Merged
anthonynsimon merged 30 commits into
ever-co:masterfrom
hackages:feature/invite-system
Sep 22, 2019
Merged

Invite system#66
anthonynsimon merged 30 commits into
ever-co:masterfrom
hackages:feature/invite-system

Conversation

@anymaniax

@anymaniax anymaniax commented Sep 14, 2019

Copy link
Copy Markdown

Copy of the pull request #24 who is a bit dead I think.

@anymaniax
anymaniax force-pushed the feature/invite-system branch from 7bdcf37 to e740f93 Compare September 14, 2019 10:38
@anymaniax
anymaniax force-pushed the feature/invite-system branch from e498381 to ed0317a Compare September 14, 2019 10:46
@anthonynsimon

anthonynsimon commented Sep 18, 2019

Copy link
Copy Markdown
Contributor

@anymaniax thanks for reviving the PR! Do you know if the branch is now feature complete? If so I can run it locally/review it. Let me know!

@anymaniax

anymaniax commented Sep 18, 2019

Copy link
Copy Markdown
Author

Normally yes :)

anthonynsimon
anthonynsimon suggested changes Sep 20, 2019
View reviewed changes

@anthonynsimon anthonynsimon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far! Some minor changes and I'd say it's good to go. Thanks a lot for reviving this feature 💯

Comment thread api/src/controllers/project-user.controller.ts
Comment thread api/src/templates/mail/invited-to-platform.txt Outdated
Comment thread api/src/domain/http.ts
Comment thread api/src/services/mail.service.ts Outdated
Comment thread webapp/src/app/projects/components/add-team-member/add-team-member.component.ts
Comment thread webapp/src/app/projects/components/team-overview/team-overview.component.html
Comment thread api/src/controllers/project-invite.controller.ts
@anthonynsimon anthonynsimon mentioned this pull request Sep 20, 2019
Closed
@anymaniax

anymaniax commented Sep 22, 2019

Copy link
Copy Markdown
Author

@anthonynsimon hey, I did everything if think can you check?

@anymaniax
anymaniax force-pushed the feature/invite-system branch from 01f2aec to 49353e1 Compare September 22, 2019 11:48
@anymaniax
anymaniax force-pushed the feature/invite-system branch from 49353e1 to 6aacc0f Compare September 22, 2019 11:53
anthonynsimon
anthonynsimon reviewed Sep 22, 2019
View reviewed changes
Comment thread api/src/templates/mail/invited-to-platform.txt Outdated
@anthonynsimon

anthonynsimon commented Sep 22, 2019

Copy link
Copy Markdown
Contributor

Thanks for the quick fixes! Looks good, after this last fix with the email template, I'd say we can add a changelog entry for the next release and merge it!

@anymaniax

anymaniax commented Sep 22, 2019

Copy link
Copy Markdown
Author

@anthonynsimon hey, I really like this project and I will try to help you when I can and have time! Did you have a discord or something where we can discuss more easily about the project?

@anthonynsimon
anthonynsimon merged commit 1f47674 into ever-co:master Sep 22, 2019
@anthonynsimon anthonynsimon added this to the Traduora 1.0 milestone Sep 22, 2019
@anthonynsimon

anthonynsimon commented Sep 22, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

@anymaniax @magyarosibotond the feature is now available on the 0.13.0 release of traduora 🎉 Thank you!

@anthonynsimon anthonynsimon mentioned this pull request Dec 12, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@anthonynsimon anthonynsimon anthonynsimon approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Traduora 1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@anymaniax @anthonynsimon @magyarosibotond