Skip to content

Conversation

@anymaniax
Copy link

Copy of the pull request #24 who is a bit dead I think.

@anymaniax anymaniax force-pushed the feature/invite-system branch from 7bdcf37 to e740f93 Compare September 14, 2019 10:38
@anymaniax anymaniax force-pushed the feature/invite-system branch from e498381 to ed0317a Compare September 14, 2019 10:46
@anthonynsimon
Copy link
Contributor

@anymaniax thanks for reviving the PR! Do you know if the branch is now feature complete? If so I can run it locally/review it. Let me know!

@anymaniax
Copy link
Author

Normally yes :)

Copy link
Contributor

@anthonynsimon anthonynsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far! Some minor changes and I'd say it's good to go. Thanks a lot for reviving this feature 💯

@anthonynsimon anthonynsimon mentioned this pull request Sep 20, 2019
@anymaniax
Copy link
Author

@anthonynsimon hey, I did everything if think can you check?

@anymaniax anymaniax force-pushed the feature/invite-system branch from 01f2aec to 49353e1 Compare September 22, 2019 11:48
@anymaniax anymaniax force-pushed the feature/invite-system branch from 49353e1 to 6aacc0f Compare September 22, 2019 11:53
@anthonynsimon
Copy link
Contributor

Thanks for the quick fixes! Looks good, after this last fix with the email template, I'd say we can add a changelog entry for the next release and merge it!

@anymaniax
Copy link
Author

@anthonynsimon hey, I really like this project and I will try to help you when I can and have time! Did you have a discord or something where we can discuss more easily about the project?

@anthonynsimon anthonynsimon merged commit 1f47674 into ever-co:master Sep 22, 2019
@anthonynsimon anthonynsimon added this to the Traduora 1.0 milestone Sep 22, 2019
@anthonynsimon
Copy link
Contributor

anthonynsimon commented Sep 22, 2019

@anymaniax @magyarosibotond the feature is now available on the 0.13.0 release of traduora 🎉 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants