Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#615 even more #738

Merged
merged 22 commits into from Mar 12, 2020
Merged

Feature/#615 even more #738

merged 22 commits into from Mar 12, 2020

Conversation

@RobinHossain
Copy link
Collaborator

RobinHossain commented Mar 10, 2020

What I did recently,

  • Fixed some UI for "Employee Type" page
  • Added as well as updated Toast messages
  • Removed extra console.log from the components
  • Added on keypress("Enter Key") event for "Employee Type" input submit action
  • Fixed typo: "Employee type" to Employment type" words as well as for structure & file names

I recorded a video for the updated/latest page preview, please have a look at the following video.
https://nimb.ws/RCEYBu

Please have a look at the following screenshots also,
https://nimb.ws/oMZlpv
https://nimb.ws/oMZlpv


ntmonov and others added 13 commits Mar 4, 2020
…e-button-organization-employee-types
…-button-organization-employee-types

Feature/#615 added update delete button organization employee types
@RobinHossain RobinHossain requested review from evereq and rmagon Mar 10, 2020
@rmagon

This comment has been minimized.

Copy link
Contributor

rmagon commented Mar 10, 2020

Nice!! I would recommend one small enhancement .. that the Save buttons only enable if there is some change to save.

@rmagon

This comment has been minimized.

Copy link
Contributor

rmagon commented Mar 10, 2020

Also please fix the Deepscan issues you see above. Otherwise it looks good .. the code changes look good. Once you're done with the above two things I'll resolve conflicts if you want me to

@RobinHossain RobinHossain force-pushed the feature/#615-even-more branch from 3a5fd50 to 482c957 Mar 11, 2020
@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Mar 11, 2020

CLA assistant check
All committers have signed the CLA.

@RobinHossain RobinHossain self-assigned this Mar 11, 2020
@evereq evereq removed the request for review from rmagon Mar 11, 2020
RobinHossain and others added 7 commits Mar 12, 2020
@evereq evereq merged commit c360cba into develop Mar 12, 2020
6 checks passed
6 checks passed
DeepScan 0 new and 0 fixed issues
Details
License Compliance All checks passed.
Details
ci/circleci: build-api Your tests passed on CircleCI!
Details
ci/circleci: build-monorepo-root Your tests passed on CircleCI!
Details
ci/circleci: build-web Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details
@evereq evereq deleted the feature/#615-even-more branch Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.