From 7d1b6fb84e38320a0ec94ab49a1801f7841d9725 Mon Sep 17 00:00:00 2001 From: Yves Duhem Date: Tue, 13 Nov 2018 11:28:00 -0500 Subject: [PATCH] PR Feedback 4 --- model/stats/query.go | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/model/stats/query.go b/model/stats/query.go index 9519a6db3db..da1c6e4130c 100644 --- a/model/stats/query.go +++ b/model/stats/query.go @@ -21,26 +21,26 @@ const ( type GroupBy string -func (gb *GroupBy) validate() error { - switch *gb { +func (gb GroupBy) validate() error { + switch gb { case GroupByDistro: case GroupByVariant: case GroupByTask: case GroupByTest: default: - return errors.Errorf("Invalid GroupBy value: %v", *gb) + return errors.Errorf("Invalid GroupBy value: %s", gb) } return nil } type Sort string -func (s *Sort) validate() error { - switch *s { +func (s Sort) validate() error { + switch s { case SortLatestFirst: case SortEarliestFirst: default: - return errors.Errorf("Invalid Sort value: %v", *s) + return errors.Errorf("Invalid Sort value: %s", s) } return nil } @@ -216,7 +216,7 @@ type TestStats struct { func GetTestStats(filter *StatsFilter) ([]TestStats, error) { err := filter.validateForTests() if err != nil { - return nil, err + return nil, errors.Wrap(err, "The provided StatsFilter is invalid") } var stats []TestStats pipeline := testStatsQueryPipeline(filter) @@ -253,7 +253,7 @@ type TaskStats struct { func GetTaskStats(filter *StatsFilter) ([]TaskStats, error) { err := filter.validateForTasks() if err != nil { - return nil, err + return nil, errors.Wrap(err, "The provided StatsFilter is invalid") } var stats []TaskStats pipeline := taskStatsQueryPipeline(filter)