added default image to config

env.sh.orig

@@ -4,3 +4,4 @@ export OAUTH_CALLBACK_URL="http://localhost:8000/hub/oauth_callback"
 export EVERWARE_WHITELIST="whitelist.txt"
 export EMAIL_SUPPORT_ADDR=
 export EMAIL_FROM_ADDR=
+export DEFAULT_DOCKER_IMAGE="yandexdataschool/neurohack-jupyter:2016.12"

everware/git_processor.py

@@ -3,6 +3,7 @@
 from concurrent.futures import ThreadPoolExecutor
 from tornado import gen
 import os
+import os.path
 
 
 class GitMixin:
@@ -104,11 +105,13 @@ def prepare_local_repo(self):
         self._repo_sha = repo.rev_parse('HEAD').hexsha
         self._branch_name = repo.active_branch.name
 
-        dockerfile_path = os.join(self._repo_dir, 'Dockerfile')
         if not os.path.isfile(dockerfile_path):
+            if not os.environ.get('DEFAULT_DOCKER_IMAGE'):
+                raise Exception('No dockerfile in repository')
             with open(dockerfile_path, 'w') as fout:
                 fout.writelines([
-                    'FROM everware/datascience-jupyter:latest\n',
                     'MAINTAINER Alexander Tiunov <astiunov@yandex-team.ru>'
                 ])
             return False

everware/spawner.py

@@ -2,6 +2,7 @@
 from datetime import timedelta
 from os.path import join as pjoin
 from shutil import rmtree
+from pprint import pformat
 
 from concurrent.futures import ThreadPoolExecutor
 
@@ -219,6 +220,33 @@ def _add_to_log(self, message, level=1):
         })
 
     @gen.coroutine
+    def wait_up(self):
+        # copied from jupyterhub, because if user's server didn't appear, it
+        # means that spawn was unsuccessful, need to set is_failed
+        try:
+            yield self.user.server.wait_up(http=True, timeout=self.http_timeout)
+            ip, port = yield from self.get_ip_and_port()
+            self.user.server.ip = ip
+            self.user.server.port = port
+            self._is_up = True
+        except TimeoutError:
+            self._is_failed = True
+            self._add_to_log('Server never showed up after {} seconds'.format(self.http_timeout))
+            self.log.info("{user}'s server never showed up after {timeout} seconds".format(
+                user=self.user.name,
+                timeout=self.http_timeout
+            ))
+            yield self.notify_about_fail("Http timeout limit %.3f exceeded" % self.http_timeout)
+            raise
+        except Exception as e:
+            self._is_failed = True
+            message = str(e)
+            self._add_to_log('Something went wrong during waiting for server. Error: %s' % message)
+            yield self.notify_about_fail(message)
+            raise e
+
+
+    @gen.coroutine
     def build_image(self):
         """download the repo and build a docker image if needed"""
         if self.form_repo_url.startswith('docker:'):
@@ -240,7 +268,7 @@ def build_image(self):
             self.log.info('Cloning repo %s' % self.repo_url)
             dockerfile_exists = yield self.prepare_local_repo()
             if not dockerfile_exists:
-                self._add_to_log('No dockerfile. Use the default one')
 
             # use git repo URL and HEAD commit sha to derive
             # the image name
@@ -302,6 +330,7 @@ def wait_up(self):
             ip, port = yield from self.get_ip_and_port()
             self.user.server.ip = ip
             self.user.server.port = port
+            self._is_up = True
         except TimeoutError:
             self._is_failed = True
             self._add_to_log('Server never showed up after {} seconds'.format(self.http_timeout))
@@ -361,37 +390,13 @@ def start(self, image=None):
             message = str(e)
             if message.startswith('Failed to get port'):
                 message = "Container doesn't have jupyter-singleuser inside"
-            elif 'Cannot locate specified Dockerfile' in message:
-                message = "Your repo doesn't include Dockerfile"
             self._add_to_log('Something went wrong during building. Error: %s' % message)
             yield self.notify_about_fail(message)
             raise e
         finally:
             self._is_building = False
 
-        # copied from jupyterhub, because if user's server didn't appear, it
-        # means that spawn was unsuccessful, need to set is_failed
-        try:
-            yield self.user.server.wait_up(http=True, timeout=self.http_timeout)
-            ip, port = yield from self.get_ip_and_port()
-            self.user.server.ip = ip
-            self.user.server.port = port
-            self._is_up = True
-        except TimeoutError:
-            self._is_failed = True
-            self._add_to_log('Server never showed up after {} seconds'.format(self.http_timeout))
-            self.log.info("{user}'s server never showed up after {timeout} seconds".format(
-                user=self.user.name,
-                timeout=self.http_timeout
-            ))
-            yield self.notify_about_fail("Http timeout limit %.3f exceeded" % self.http_timeout)
-            raise
-        except Exception as e:
-            self._is_failed = True
-            message = str(e)
-            self._add_to_log('Something went wrong during waiting for server. Error: %s' % message)
-            yield self.notify_about_fail(message)
-            raise e
 
 
     @gen.coroutine