Permalink
Browse files

Incorporate comments from @anaderi

  • Loading branch information...
1 parent 17dc025 commit 7fa1cd25b4e58b2eea62f063825acd6d074ad083 @betatim betatim committed Mar 20, 2016
Showing with 5 additions and 1 deletion.
  1. +5 −1 CONTRIBUTING.md
View
@@ -43,7 +43,7 @@ and click 'Pull request' to send your changes to the maintainers for
review. This will send an email to the committers. A valid PR includes
the following items:
-* a description of the problem you are solving
+* a description of the problem you are solving or reference to existing issue
* a discussion why you made the choices you made
* contains the minimal set of changes needed to solve the problem (do
not mix several issues, rather create separate PRs)
@@ -53,6 +53,10 @@ the following items:
and comments
* no commits merging master into your branch, instead rebase your branch
+These are guidelines and not hard rules, so if you feel one of them does not
+apply, write a short sentence in the PR's description explaining why you
+skipped it.
+
We encourage you to start your PR as soon as possible to get feedback early.
Mark it as `[WIP] your subject` if it is not ready for merging. We will try and
respond as quickly as possible, but we are all volunteers so it might take 24h.

0 comments on commit 7fa1cd2

Please sign in to comment.