Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bring Your Own Resources #205

Merged
merged 23 commits into from Jun 30, 2017
Jump to file or symbol
Failed to load files and symbols.
+3 −4
Split
Viewing a subset of changes. View all

minor fixes

commit 46a8ac78a5bc0dd06a7ba893c414f97c175b3e02 @StrausMG StrausMG committed Jun 24, 2017
View
@@ -2,5 +2,4 @@
load_subconfig('etc/base_config.py')
load_subconfig('etc/github_auth.py')
-from dockerspawner import DockerSpawner
-c.DockerSpawner.hub_ip_connect = c.JupyterHub.hub_ip
+c.JupyterHub.spawner_class = 'everware.ByorDockerSpawner'
View
@@ -365,7 +365,7 @@ def remove_old_container(self):
force=True
)
except APIError as e:
- self.log.info("Can't erase container %s due to %s" % (self.container_name, e))
+ self.log.info("Can't erase container %s due to %s" % (self.container_name, e))
@anaderi

anaderi Jun 21, 2017

Owner

remove trailing space

@gen.coroutine
def start(self, image=None):
@@ -50,7 +50,7 @@
<p style="margin-bottom: 0px;">
For a successful run <a href="https://www.docker.com/" target="_black">Docker</a>
must be installed on your server.<br />
- Enter ip and port of the Docker daemon running on your server.<br />
+ Enter IP address and port of the Docker daemon running on your server.<br />
(Click <a href="https://docs.docker.com/engine/reference/commandline/dockerd/#daemon-socket-option"
target="_blank">
here</a> to learn how to run Docker daemon on a particular port)