Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add basic push to Github functionality #49

Merged
merged 20 commits into from Mar 15, 2016

Conversation

Projects
None yet
3 participants
Owner

ibab commented Mar 5, 2016

This will allow users to store their changes by pushing them back to Github.

This was referenced Mar 7, 2016

Owner

ibab commented Mar 9, 2016

Maybe we should just push this now before I procrastinate more on it? 😆
We can improve it in another PR

ibab changed the title from [WIP] Add basic push to Github functionality to Add basic push to Github functionality Mar 9, 2016

Owner

betatim commented Mar 9, 2016

Can you poke travis?

If this isn't obviously broken/totally confusing for the user then I would also vote to merge early and often.

Owner

ibab commented Mar 9, 2016

Travis has been poked.

Owner

ibab commented Mar 9, 2016

Can someone decipher why he is unhappy?

Owner

betatim commented Mar 9, 2016

jupyterhub didn't start so the tests fail. I created #65 to track this.

The reason this fails now is that we use the latest released version of jupyterhub, which got bumped last night. Should hard code the version probably. @anaderi included the fix for this in #59 but waiting to hear from him re merging it. If you can take a look at #59 and are happy I will merge it. Then rebase this and travis should be happy again.

Owner

betatim commented Mar 9, 2016

Poke the bear, do it!

Owner

anaderi commented Mar 9, 2016

the problem I had was due to absence of '--no-ssl' flag at latest tag.
problem you have seems to be a bit different:

    Traceback (most recent call last):
      File "/home/travis/virtualenv/python3.4.3/lib/python3.4/site-packages/tornado/web.py", line 1445, in _execute
        result = yield result
      File "/home/travis/virtualenv/python3.4.3/lib/python3.4/site-packages/everware/home_handler.py", line 166, in get
        login_service=user.login_service,
      File "/tmp/jupyterhub/jupyterhub/user.py", line 134, in __getattr__
        raise AttributeError(attr)
    AttributeError: login_service

I'm not sure what might cause that. Do you have travis working for your fork?

@anaderi anaderi added a commit that referenced this pull request Mar 15, 2016

@anaderi anaderi Merge pull request #49 from ibab/editing
Add basic push to Github functionality, finally
2986d82

@anaderi anaderi merged commit 2986d82 into everware:master Mar 15, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment