String replacements causing corrupted .zip files

[WilliamVenner]

Expected Behavior

The .zip file works

Actual Behavior

The .zip file cannot be extracted by Windows Explorer.
WinRAR and 7z have no problem.

Reproduction Steps

Customer 76561198093255661 has informed me all my addons other than my admin sits addon cause this issue, download the beta version of those scripts on his account and it should reproduce

Browsers

No response

Example URL

No response

GmodStore Version

No response

Event ID

No response

Additional Information

No response

[danfmn]

I'm also experiencing this issue :-/

[TheodoorP]

@danfmn please provide some reproduction steps, such as which addons and releases cause this issue.

[danfmn]

@TheodoorP Any of Billy's addons latest releases. He includes Reproduction steps above.

[TheodoorP]

I'm only able to replicate this in billy's whitelist, billy's admin sites and gluapack. It seems to happen with the license.lua files and gluapack_license.mdmp.

[WilliamVenner]

@TheodoorP I'm not doing anything special. I am just returning a hex string as my response. No binary or anything.

[Marcuzz]

Debugging this is not easy when only Windows Explorer seems to think the file is corrupt, without giving any additional information other than Error 0x80004005: Unspecified error. It is definitely related to files that are touched by string replacements, but we are not performing any mutations that are out of the ordinary.

[WilliamVenner]

Please can you look into this again, customers are still getting this regularly and they do not understand it.

It only happens on files whose contents are only file string replacements.

[J0sh0nat0r]

It seems Windows' zip implementation is picky about file compression, this was fixed by using zlib's implementation of deflate.

[WilliamVenner]

I assumed you guys were using the zip crate?

[Marcuzz]

I assumed you guys were using the zip crate?

Yes, and we still are