Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed symfony:doctrine:schema:drop - added --force #319

Merged
merged 3 commits into from Jan 21, 2013

Conversation

Projects
None yet
2 participants
Contributor

viliam-husar commented Jan 17, 2013

Task symfony:doctrine:schema:drop never actually droped schema because of missing --force parameter.

viliam-husar added some commits Jan 17, 2013

Fixed symfony:doctrine:schema:drop - added --force
Task symfony:doctrine:schema:drop never actually droped schema because of missing --force parameter.
Added confirmation to doctrine drops tasks
Fixed symfony:doctrine:database:drop (missed --force argument too).
Added confirmation for symfony:doctrine:database:drop and 
symfony:doctrine:schema:drop.
Contributor

viliam-husar commented Jan 17, 2013

I understand your concern, so I added a confirmation you suggested. There was same issue with symfony:doctrine:database:drop task. I changed that too.

Collaborator

willdurand commented Jan 17, 2013

What about adding a few examples to the test suite?

Contributor

viliam-husar commented Jan 18, 2013

Done.

willdurand added a commit that referenced this pull request Jan 21, 2013

Merge pull request #319 from solzenic/patch-1
Fixed symfony:doctrine:schema:drop - added --force

@willdurand willdurand merged commit c878e14 into everzet:master Jan 21, 2013

Collaborator

willdurand commented Jan 21, 2013

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment