Compatibility to Capistrano 2.14.1 #320

Merged
merged 1 commit into from Jan 20, 2013

Conversation

Projects
None yet
3 participants
Contributor

KingCrunch commented Jan 17, 2013

My ubuntu system always wants to install capistrano-2.14.1 and I always must uninstall it to get capifony working again, so I thought I have a look which changes are required to make it work with the newer version. Unfortunately I had to rename a task, because load as a taskname leads to an error. In this PR I renamed doctrine:fixtures:load to doctrine:load_fixtures, because it was the only fixtures-task anyway. I think the (new) name of the task, or even this PR as a whole is open for discussion now 😄

  • 2.13.5 still works
  • Tests passes (what also means, that there were no tests for this task ☺️)
Collaborator

willdurand commented Jan 17, 2013

Really? load can't be used as taskname? Don't we have other methods named with load?

Contributor

KingCrunch commented Jan 18, 2013

It triggers something like "There is already a task with name load". I'll post the concrete message later.

Don't we have other methods named with load?

$ cap -T | grep -i "load"

There are some tasks load_foo, but there is really only one load. Show a complete list later too

Collaborator

willdurand commented Jan 18, 2013

Okay.

William Durand | http://www.williamdurand.fr

On Fri, Jan 18, 2013 at 8:51 AM, Sebastian Krebs
notifications@github.comwrote:

It triggers something like "There is already a task with name load". I'll
post the concrete message later.

Don't we have other methods named with load?

$ cap -T | grep -i "load"

There are some tasks load_foo, but there is really only one load. Show a
complete list later too


Reply to this email directly or view it on GitHubhttps://github.com/everzet/capifony/pull/320#issuecomment-12410999.

Contributor

KingCrunch commented Jan 19, 2013

Capifony 2.2.6 on Capistrano 2.14.1

$ cap -T
/usr/lib/ruby/1.9.1/rubygems/specification.rb:1637:in `raise_if_conflicts': Unable to activate capifony-2.2.6, because capistrano-2.14.1 conflicts with capistrano (~> 2.13.5) (Gem::LoadError)

from /usr/lib/ruby/1.9.1/rubygems/specification.rb:746:in `activate'
from /usr/lib/ruby/1.9.1/rubygems.rb:212:in `rescue in try_activate'
from /usr/lib/ruby/1.9.1/rubygems.rb:209:in `try_activate'
from /usr/lib/ruby/1.9.1/rubygems/custom_require.rb:59:in `rescue in require'
from /usr/lib/ruby/1.9.1/rubygems/custom_require.rb:35:in `require'
from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/lib/capistrano/configuration/loading.rb:152:in `require'
from Capfile:5:in `load'
from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/lib/capistrano/configuration/loading.rb:93:in `instance_eval'
from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/lib/capistrano/configuration/loading.rb:93:in `load'
from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/lib/capistrano/configuration/loading.rb:172:in `load_from_file'
from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/lib/capistrano/configuration/loading.rb:89:in `load'
from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/lib/capistrano/configuration/loading.rb:86:in `block in load'
from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/lib/capistrano/configuration/loading.rb:86:in `each'
from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/lib/capistrano/configuration/loading.rb:86:in `load'
from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/lib/capistrano/cli/execute.rb:65:in `block in load_recipes'
from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/lib/capistrano/cli/execute.rb:65:in `each'
from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/lib/capistrano/cli/execute.rb:65:in `load_recipes'
from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/lib/capistrano/cli/execute.rb:31:in `execute!'
from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/lib/capistrano/cli/execute.rb:14:in `execute'
from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/bin/cap:4:in `<top (required)>'
from /usr/local/bin/cap:23:in `load'
from /usr/local/bin/cap:23:in `<main>'

Capifony 2.2.6 on Capistrano 2.13.5

$ cap -vT | grep load
cap database:move:to_local                  # Dumps remote database, download...
cap database:move:to_remote                 # Dumps local database, loads it ...
cap deploy:upload                           # Copy files to the currently dep...
cap symfony:composer:dump_autoload          # Dumps an optimized autoloader
cap symfony:doctrine:fixtures:load          # Load data fixtures
cap symfony:propel:build:acl_load           # Inserts propel ACL tables
cap symfony:propel:build:all_and_load       # Builds the Model classes, SQL s...
cap symfony:propel:build:sql_load           # Inserts SQL statements

symfony:doctrine:fixtures:load is the only task named load, all others have only "load" as part of their name, or in their description.

Collaborator

willdurand commented Jan 19, 2013

oO

English please?

Le 19 janv. 2013 à 13:03, Sebastian Krebs notifications@github.com a écrit :

Capifony 2.2.6 auf Capistrano 2.14.1

$ cap -T
/usr/lib/ruby/1.9.1/rubygems/specification.rb:1637:in `raise_if_conflicts': Unable to activate capifony-2.2.6, because capistrano-2.14.1 conflicts with capistrano (~> 2.13.5) (Gem::LoadError)

from /usr/lib/ruby/1.9.1/rubygems/specification.rb:746:in activate' from /usr/lib/ruby/1.9.1/rubygems.rb:212:inrescue in try_activate'
from /usr/lib/ruby/1.9.1/rubygems.rb:209:in try_activate' from /usr/lib/ruby/1.9.1/rubygems/custom_require.rb:59:inrescue in require'
from /usr/lib/ruby/1.9.1/rubygems/custom_require.rb:35:in require' from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/lib/capistrano/configuration/loading.rb:152:inrequire'
from Capfile:5:in load' from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/lib/capistrano/configuration/loading.rb:93:ininstance_eval'
from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/lib/capistrano/configuration/loading.rb:93:in load' from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/lib/capistrano/configuration/loading.rb:172:inload_from_file'
from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/lib/capistrano/configuration/loading.rb:89:in load' from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/lib/capistrano/configuration/loading.rb:86:inblock in load'
from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/lib/capistrano/configuration/loading.rb:86:in each' from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/lib/capistrano/configuration/loading.rb:86:inload'
from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/lib/capistrano/cli/execute.rb:65:in block in load_recipes' from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/lib/capistrano/cli/execute.rb:65:ineach'
from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/lib/capistrano/cli/execute.rb:65:in load_recipes' from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/lib/capistrano/cli/execute.rb:31:inexecute!'
from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/lib/capistrano/cli/execute.rb:14:in execute' from /var/lib/gems/1.9.1/gems/capistrano-2.14.1/bin/cap:4:in<top (required)>'
from /usr/local/bin/cap:23:in load' from /usr/local/bin/cap:23:in

'
Capifony 2.2.6 auf Capistrano 2.13.5

$ cap -vT | grep load
cap database:move:to_local # Dumps remote database, download...
cap database:move:to_remote # Dumps local database, loads it ...
cap deploy:upload # Copy files to the currently dep...
cap symfony:composer:dump_autoload # Dumps an optimized autoloader
cap symfony:doctrine:fixtures:load # Load data fixtures
cap symfony:propel:build:acl_load # Inserts propel ACL tables
cap symfony:propel:build:all_and_load # Builds the Model classes, SQL s...
cap symfony:propel:build:sql_load # Inserts SQL statements
Das heißt, die einzige Task, die genau load heißt, ist die von fixtures. Überraschte mich auch, ist aber jetzt ganz vorteilhaft :)


Reply to this email directly or view it on GitHub.

Contributor

KingCrunch commented Jan 19, 2013

@willdurand Oh, sorry, my fault! 😪 Edited the last reply

Collaborator

willdurand commented Jan 19, 2013

Did you run the test suite?

Contributor

KingCrunch commented Jan 19, 2013

@willdurand Yes, all test pass for both 2.13 and 2.14

willdurand merged commit ea7ba1f into everzet:master Jan 20, 2013

Collaborator

willdurand commented Jan 20, 2013

Tip top, thanks

I'm still having a tonne of compatibility problems between recent versions of Capistrano and Capifony.

Are we sure they're compatible and that the tests give sufficient coverage?

I get various errors with different version combos such as undefined method pretty_print and log_path.

I had no problems across any of my projects up until a few weeks ago, but now more often than not I'm unable to deploy and having great difficulty resolving the compatibility problems.

Contributor

KingCrunch commented Jan 30, 2013

@stevelacey

Are we sure they're compatible and that the tests give sufficient coverage?

No 😄 What I can say is, that I don't have any problems with capifony-latest and capistrano-2.14. What for problems do you have an which capistrano version do you use? Are you sure, that this is related with the capistrano-capifony-combination, or do you have any other recipes in place, that may cause this error?

I get various errors with different version combos such as undefined method pretty_print and log_path.

At least pretty_print is renamed into capifony_pretty_print for a while now. I had a similar problem and the problem was, that a third party recipe was 6 months old and use the pretty_print-method of capifony, that disappeared in the meantime.

@stevel

KingCrunch deleted the unknown repository branch Jan 30, 2013

Yeah, just worked out that now, it was primarily because of me having neglected renaming all of my own calls to pretty_print and a couple of other problems. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment