Updated lesscss to current release 1.1.3 #6

Merged
merged 3 commits into from Dec 19, 2011

2 participants

@vworldat

I've removed the quite old version 1.0.33 of less and added 1.1.3.
There's also a small fix for the web debug panel in non-webroot environments.

@everzet everzet merged commit 738e274 into everzet:master Dec 19, 2011
@ibolmo ibolmo commented on the diff Jan 3, 2013
lib/less/sfLESS.class.php
{
- try
- {
- $fs->execute($command, null, array($this, 'throwCompilerError'));
- }
- catch (RuntimeException $e)
- {
- return false;
- }
+ require_once(sfConfig::get('sf_lib_dir').'/vendor/lessc.inc.php');
@ibolmo
ibolmo added a line comment Jan 3, 2013

Isn't this pointing to {root}/lib/vendor and not to {root}/plugins/sfLESSPlugin/lib/vendor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@ibolmo ibolmo commented on the diff Jan 3, 2013
lib/config/sfLESSConfig.class.php
@@ -67,6 +67,14 @@ public function isClientSideCompilation()
}
/**
+ * @see LESSConfig
+ */
+ public function isUseLessphp()
+ {
+ return sfConfig::get('app_sf_less_plugin_use_lessphp', parent::isClientSideCompilation());
@ibolmo
ibolmo added a line comment Jan 3, 2013

This should have been $this->isClientSideCompilation() since it skips:


  /**
   * @see LESSConfig
   */
  public function isClientSideCompilation()
  {
    return sfConfig::get('app_sf_less_plugin_use_js', parent::isClientSideCompilation());
  }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment