Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback v1.0.0-canary.1 #41

Closed
108kb opened this issue Jul 1, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@108kb
Copy link
Member

commented Jul 1, 2019

Bug/Need enhancement

  • Total bundle size ~2.61MB! (app)
  • Navbar si tombol Back nya ngilang. Inilah pentingnya test (app)
  • Navbar title ngilang! Inilah pentingnya test. (app)
  • Belum buat snapshot (app)
  • Theme color masih #000 (app)
  • Logo (di Appbar) terlalu besar (app)
  • add sw.js to routes (app)
  • NADYA_APP_VER build environment masih gak jalan. Related with Zeit Now (infra)
  • deploy ke canary tapi ke deploy ke app juga, still investigate. (infra)

Feature

  • Show (actual) notification (app)
  • Integrate with codecov.io (infra)
  • Option to delete local data (app)
@108kb

This comment has been minimized.

Copy link
Member Author

commented Jul 1, 2019

Blocking #40

@ri7nz

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

@108kb

This comment has been minimized.

Copy link
Member Author

commented Jul 1, 2019

my mean the logo dimension, not the size itself. but will trying it out, thanks.

108kb added a commit that referenced this issue Jul 2, 2019

108kb added a commit that referenced this issue Jul 2, 2019

108kb added a commit that referenced this issue Jul 2, 2019

108kb added a commit that referenced this issue Jul 2, 2019

@108kb 108kb referenced this issue Jul 2, 2019

Merged

v1.0.0-canary.2 #42

@108kb 108kb changed the title Feedback v1.0.0-rc.1 Feedback v1.0.0-canary.1 Jul 2, 2019

@108kb 108kb closed this in 818b429 Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.