Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Crash adding large series #181

Closed
mightyflub opened this Issue · 5 comments

2 participants

@mightyflub

I added 2000ad (4 figure series) and got this crash towards the end of it gathering a list of issues

Issue: 1813.00
sale-date..ParseDate:2013-01-02
Parsed Date length: 11
Parse date: 2013-01-02
24-Jan-2013 14:56:13 - INFO :: Thread-26 : Sucessfully retrieved details for 2000 AD
24-Jan-2013 14:56:14 - INFO :: Thread-26 : Sucessfully retrieved cover for 2000 AD
24-Jan-2013 14:58:13 - INFO :: Thread-26 : Sucessfully retrieved issue details for 2000 AD
24-Jan-2013 14:58:13 - INFO :: Thread-26 : Now adding/updating issues for 2000 AD
24-Jan-2013 14:58:13 - INFO :: Thread-26 : Checking directory for existing issues.
Exception in thread Thread-26:
Traceback (most recent call last):
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 552, in __bootstrap_inner
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 505, in run
File "/Users/u0011116/webapps/mylar/mylar/importer.py", line 346, in addComictoDB
myDB.upsert("issues", newValueDict, controlValueDict)
File "/Users/u0011116/webapps/mylar/mylar/db.py", line 96, in upsert
self.action(query, valueDict.values() + keyDict.values())
File "/Users/u0011116/webapps/mylar/mylar/db.py", line 62, in action
sqlResult = self.connection.execute(query, args)
InterfaceError: Error binding parameter 3 - probably unsupported type.

Here's the mylar.log section

24-Jan-2013 14:54:42 - DEBUG :: Thread-26 : number of issues I counted: 1830
24-Jan-2013 14:54:42 - DEBUG :: Thread-26 : number of issues CV says it has: 1826
24-Jan-2013 14:54:42 - DEBUG :: Thread-26 : vari is set to: yes
24-Jan-2013 14:54:42 - INFO :: Thread-26 : Now adding/updating: 2000 AD
24-Jan-2013 14:56:13 - INFO :: Thread-26 : Sucessfully retrieved details for 2000 AD
24-Jan-2013 14:56:14 - INFO :: Thread-26 : Sucessfully retrieved cover for 2000 AD
24-Jan-2013 14:56:19 - DEBUG :: Thread-26 : issues I've counted: 1830
24-Jan-2013 14:56:19 - DEBUG :: Thread-26 : issues CV says it has: 1826
24-Jan-2013 14:56:19 - DEBUG :: Thread-26 : CV's count is wrong, I counted different...going with my count for physicals1830
24-Jan-2013 14:58:13 - INFO :: Thread-26 : Sucessfully retrieved issue details for 2000 AD
24-Jan-2013 14:58:13 - INFO :: Thread-26 : Now adding/updating issues for 2000 AD
24-Jan-2013 14:58:13 - INFO :: Thread-26 : Checking directory for existing issues.

There are no existing issues in the folder.

@evilhero
Owner

Were you adding it via the Ultron Error-Checker ? I just tried to add the 2000 AD series from 1977 that had 1826 issues and it threw me into there.Which one are you trying to link it to from GCD ?

NM - I figured it out, that should be detecting as a multi-volume series, so we need to add something to the custom_exceptions.csv denoting it....stay tuned :)

@evilhero evilhero referenced this issue from a commit
@evilhero FIX: (#181) 2000 AD exception added to csv for mulit-volume support, …
…FIX: ComicYear was parsed wrong when using multi-volume occassionally, IMP: Turned off console printing for parsing
a831608
@mightyflub

Excellent. Thanks :) Is that because it's had multiple publishers?

@evilhero
Owner

No actually when a series goes thru reboots, renumbering, volume changes it'll get lumped into that - changes to the publisher don't really matter according to GCD. Comicvine doesn't distinguish between these and just says the overall count (in this case 1826), but gcd breaks it down by volumes (more or less) which is why there are so many hits on GVD for this title. Usually a big hint is if the numbering continues over several volumes.

@mightyflub

That's really weird because the only significant thing to ever happen to 2000ad is the publisher change in 2001. It's never had a concept of volumes at all (That's reserved for the sister title Judge Dredd Megazine). It's considered by everyone including the publisher to be one straight run through and is numbered that way.

@evilhero
Owner

Hopefully you got it added ok after the commit. If you look on comics.org for 2000 a.d you'll see the different volumes which was causing the problem.

@evilhero evilhero was assigned
@claym claym referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@claym claym referenced this issue from a commit
@evilhero FIX: (#181) 2000 AD exception added to csv for mulit-volume support, …
…FIX: ComicYear was parsed wrong when using multi-volume occassionally, IMP: Turned off console printing for parsing
365d88c
@evilhero evilhero closed this
@Corb3nik Corb3nik referenced this issue from a commit
@evilhero FIX: (#181) 2000 AD exception added to csv for mulit-volume support, …
…FIX: ComicYear was parsed wrong when using multi-volume occassionally, IMP: Turned off console printing for parsing
b3d2eb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.