test @texet/color in chart render#152
Closed
AlexDroomer wants to merge 1 commit intoevilmartians:mainfrom
Closed
Conversation
Member
Hm, is it the better way to optimize it? Can you open another PR with that? Maybe it is better than using |
Contributor
Author
Check it #153 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test env
--benchmark-color: #a36825
searchParams: ?bench#70,0.1,296,100
Initial benchmark
Freeze max 20
Freeze sum 23
Worker max 50
Worker sum 177
Paint 52
benchmark with culori inGamut(colorSpace)
Freeze max 5
Freeze sum 7
Worker max 46
Worker sum 149
Paint 46
texet/color benchmark
Freeze max 4
Freeze sum 5
Worker max 56
Worker sum 195
Paint 58
Chart rendering works. During the measurement process, I discovered that when converting oklch to another color space in texet, the resulting values differ from culori ±2e-9 to ±2e-10