Render slices on 3d object #95
Conversation
|
I sent it to our designer. For me it looks awesome. |
|
Looks awesome for both of us. Tomorrow will do a review if we are ready. |
lib/model.ts
Outdated
| if (!fullControl) { | ||
| updateSelectors(selectorL, selectorC, selectorH, current.get()) | ||
| } | ||
| current.listen(value => { |
There was a problem hiding this comment.
Why we need to listen current for cull-screen model (we do not need to draw lines on fullscreen)
There was a problem hiding this comment.
If we are in fullscreen current would not be updating anyway, so it does not influence anything. Shaders are reset to default value, so selectors are not visible in fullscreen
There was a problem hiding this comment.
But why we need this line in full-screen? Can we move it to if (!fullControl)?
There was a problem hiding this comment.
Sure, I made the change, also automatically fixed some formatting
|
Wow! That looks awesome! Thank you, @muddv. Isn’t it too late to make lines thinner? I think half of the current stroke would be great. |
Thank you! Making lines thinner is a quick change, here is how it would look like at half of current width: |
Related to #90
Currently 3d object look like this:
And here it is in action:
https://user-images.githubusercontent.com/73133951/227347489-7bea7f0b-9724-4c7c-aefa-5f993c2efe07.mp4