Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
omniauth-ebay-oauth implementation #2
Thank you for quick and clean implementation!
Some things that should be fixed for use in real apps:
eBay username. It's unreliable to use it as user identifier as it may be changed by the user.
See the code comment for details.
In real apps, it is important to know when
refresh_tokenwill expire to send a reminder to the user, asking to log in again. Also, it allows distinguishing between token expiration and token revocation by the user.
OAuth scopes. Empty scope list is fine for sign-in purposes, but it should be documented better IMHO.
Also, an example should be added (should user concatenate the list of scopes with space or can we do it for them?)