-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
really install the requested version of bundler #24
Conversation
fixes evilmartians#23 Bundler won't uninstall because it is a 'default' gem and you won't end up running the version you added. Deleting the default gemspec first removes its protection. 'dip bundle -v' to check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks!
Just one minor comment.
@@ -56,7 +56,9 @@ ENV LANG=C.UTF-8 \ | |||
|
|||
# Upgrade RubyGems and install required Bundler version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a link to this PR to the comment for clarification?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it okay now?
Thanks! |
I'm afraid it causes trouble, here's what I'm getting with this approach when trying to run
And I am getting it when this exact bundler is installed and running the suggested command does not change a thing. I've "reverted" the changes this PR introduces and everything works well just as it was before. |
Fair enough....but strange...I am using this every single day, also with the refinement of only running it when I definitely need a specific version of bundler:
|
I reverted this and it works good for me just updating the system and installing the specific version |
The same for us: We had to revert this to get rspec to work in RubyMine again. (On the console using dip, rspec was already working fine.) |
BTW, since 2.3.0 it's simpler to deal with different versions - bundler will install it automatically. |
fixes #23
Bundler won't uninstall because it is a 'default' gem and you won't end up running the version you added. Deleting the default gemspec first removes its protection. 'dip bundle -v' to check