Adds step in Dockerfile to include freedesktop.org.xml #35
Conversation
* This is now required to install the mimemagic gem, which is a transitive dependency of Active Storage.
| && apt-get clean \ | ||
| && rm -rf /var/cache/apt/archives/* \ | ||
| && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* \ | ||
| && truncate -s 0 /var/log/*log | ||
|
|
||
| RUN cp /usr/share/mime/packages/freedesktop.org.xml ./ \ |
There was a problem hiding this comment.
This step is excess because of image size will not be reduced at the end.
There was a problem hiding this comment.
Yeah.
We should either move the first cp and the apt-get remove commands to the RUN above or add an independent RUN apt-get update ..... apt-get clean ... just for this functionality.
I prefer the second approach.
@bibendi @PhilCoggins Thoughts?
There was a problem hiding this comment.
I prefer to just install the package and don't do any actions after :)
By the way, is this fix needed after the recent fixes at active-storage's dependencies?
There was a problem hiding this comment.
By the way, is this fix needed after the recent fixes at active-storage's dependencies?
Not sure, but I just found that my app doesn't work without it 😁
|
Merged 525e58d Thanks! |
👋 I saw the terraforming-rails talk in person, and more recently the Ruby on Whales blogpost has been crucial in helping me setup Docker at my company, thank you!
I wanted to give back, the Dockerfile used in the blogpost now requires
freedesktop.org.xmlto install themimemagicgem as theshared-mime-infopackage is not installed on slim Docker images. It would be great to see a corresponding blog post update to help future Rails devs configure Docker for their Rails app without the mime headaches.See also: docker-library/ruby#344