Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

FIX: Handle URLs with apostrophes in them. #164

Merged
merged 1 commit into from Feb 13, 2014

Conversation

Projects
None yet
2 participants
Contributor

eviltrout commented Jan 21, 2014

This fix supports simple links to URLs with apostrophes in them.

@evilstreak evilstreak commented on the diff Feb 4, 2014

src/dialects/gruber.js
@@ -654,10 +657,16 @@ define(['../markdown_helpers', './dialect_helpers', '../parser'], function (Mark
return [ consumed, link ];
}
+ m = text.match(new RegExp("^\\((" + urlRegexp + ")\\)"));
+ if (m && m[1]) {
@evilstreak

evilstreak Feb 4, 2014

Owner

Why does this need to be a separate block rather than a modification of the regex used in the previous block (~40 lines above)?

@eviltrout

eviltrout Feb 5, 2014

Contributor

I think I tried to do that originally but couldn't get the regexp to work properly. It was just beyond my capabilities of regular expression-fu. If someone else could show me how to do that I'd appreciate it, but in the meantime this works for the tests.

@evilstreak

evilstreak Feb 13, 2014

Owner

I've not managed to look at this yet, and won't get a chance for at least a couple more weeks, so I'm just going to merge this as is

evilstreak added a commit that referenced this pull request Feb 13, 2014

Merge pull request #164 from eviltrout/apostrophe
FIX: Handle URLs with apostrophes in them.

@evilstreak evilstreak merged commit 2a38708 into evilstreak:master Feb 13, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment