Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3: Add CSS styling for text overflow #4

Merged
merged 1 commit into from Sep 24, 2019

Conversation

@hansal7014
Copy link
Contributor

hansal7014 commented Sep 20, 2019

Issue Description

As described in Issue #3 , if there is too much text in one section, it will expand into the next section.

Code Changes

Added CSS styling to handle text overflow.

Unit Test

Scrollbar appears when the text overflows in any section. See unit test image below:

Checklist

  • Unit tests
  • Documentation is up to date
  • Followed coding standards
@Sbaah

This comment has been minimized.

Copy link

Sbaah commented Sep 23, 2019

Reviews of Other Student's Pull Requests

Compare the Pull Request to the related Issue it is trying to fix. Has everything been covered?

Yes

Confirm that there are no other related Issues or Pull Requests that might conflict with this Pull Request

Yes there are no other related issues or pull requests that might conflict with this pull request

Review code and other changes, making comments and suggestions about any improvements you can see, or other issues that need to be addressed.

Non required from me!

@evlnyng

This comment has been minimized.

Copy link
Owner

evlnyng commented Sep 24, 2019

Thank you!

@evlnyng evlnyng closed this Sep 24, 2019
@evlnyng evlnyng reopened this Sep 24, 2019
@evlnyng evlnyng merged commit d5d2693 into evlnyng:master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.