Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitting dependencies over multiple lines only works if backslash preceded by space #33

Closed
cmungall opened this issue Dec 29, 2016 · 1 comment
Closed

Splitting dependencies over multiple lines only works if backslash preceded by space #33

cmungall opened this issue Dec 29, 2016 · 1 comment
Labels
GNU make compatibility

Comments

@cmungall
Copy link
Member

cmungall commented Dec 29, 2016 •
edited

this works:

foo: bar1 \
 bar2
	echo done $^

this fails to parse:

foo: bar1\
 bar2
	echo done $^

easy to modify a Makefile to conform, but not clear why this should be the case
@cmungall
Copy link
Member Author

cmungall commented Dec 29, 2016 •
edited

previous comment deleted as I was doing something dumb...

cmungall added a commit that referenced this issue Dec 29, 2016
@cmungall
Fix to prevent over-eager consumption of backslashes as part of target.
2d072b3 
Fixes #33
Previously a string "bar1\\\nbar2" would not parse using makefile_targets//1,
this was because the first target was being parsed as "bar\\", breaking
the "\\\n" whitespace delimiter.
@cmungall cmungall mentioned this issue Dec 29, 2016
Merged
@ihh ihh closed this as completed in #34 Dec 30, 2016
ihh added a commit that referenced this issue Dec 30, 2016
@ihh
Added test for #33
2f6394c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GNU make compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cmungall