New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove override of createJSModules #446

merged 1 commit into from Aug 2, 2017
Changes from all commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.
+0 −5
Diff settings


Just for now

@@ -23,11 +23,6 @@ public FIRMessagingPackage(){
return modules;

public List<Class<? extends JavaScriptModule>> createJSModules() {
return Collections.emptyList();

public List<ViewManager> createViewManagers(ReactApplicationContext reactContext) {
return Arrays.<ViewManager>asList();
ProTip! Use n and p to navigate between commits in a pull request.