New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awkward/incorrect English wording "has existed" #329

Closed
movermeyer opened this Issue May 29, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@movermeyer
Contributor

movermeyer commented May 29, 2017

  • Operating system: All
  • Pencil version: 3.0.2

The wording of two dialog boxes is not proper English. This was originally noticed by @thinw002, as reported in #320:

  • The page name 'Test1' has existed should be The page name 'Test1' already exists
    similarly:
  • Font name 'TestFont' has existed. should be Font name 'TestFont' already exists.

A pull request will arrive shortly.

@movermeyer movermeyer changed the title from Awkward English translation "has existed" to Awkward/incorrect English wording "has existed" May 29, 2017

@movermeyer

This comment has been minimized.

Contributor

movermeyer commented May 30, 2017

You might want to consider using some internationalization (i18n) library to allow for easier translation of Pencil into other languages.

dgthanhan added a commit that referenced this issue Jun 5, 2017

Merge pull request #330 from movermeyer/has_existed_typo
Fixing English wording of two dialog boxes. Fixes #329

@mbrainiac mbrainiac closed this in 4676356 Jun 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment