Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSIS Bad Encoding and Unicode #17

Closed
evshiron opened this issue Apr 13, 2017 · 1 comment
Closed

NSIS Bad Encoding and Unicode #17

evshiron opened this issue Apr 13, 2017 · 1 comment
Labels

Comments

@evshiron
Copy link
Owner

@evshiron evshiron commented Apr 13, 2017

Today someone told me NSIS might complain about "Bad Encoding" if Chinese characters are used in description and so on. I couldn't reproduce it but providing NSIS Unicode support might help.

But in my experiments, the provided appName remains the same weird characters (UTF-8 bytes as ANSI characters) no matter whether Unicode true is set or not.

NSIS Unicode supports UTF-8 and UTF-16LE charsets, but UTF-16LE just wouldn't parse in NSIS 3 if I was doing it in the right way, and UTF-8 was treated as ANSI.

What should I do next?

@evshiron

This comment has been minimized.

Copy link
Owner Author

@evshiron evshiron commented Apr 14, 2017

The issue resolves after using /INPUTCHARSET UTF8 in makensis arguments, and I am just too lazy to expose build.nsis.unicode and build.nsis.langId until someone asks me.

@evshiron evshiron closed this Apr 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.