From b5f47ae1cc4b5889b8a50bfd767e7848cca275f4 Mon Sep 17 00:00:00 2001 From: Benjy Date: Fri, 5 Apr 2013 18:10:43 -0700 Subject: [PATCH] Make missing dep errors actual errors. Remove some commented-out code that wouldn't even work any more if it were uncommented. Auditors: markcc --- src/python/twitter/pants/tasks/jvm_dependency_cache.py | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/python/twitter/pants/tasks/jvm_dependency_cache.py b/src/python/twitter/pants/tasks/jvm_dependency_cache.py index f2c7aa35a..cca63c475 100644 --- a/src/python/twitter/pants/tasks/jvm_dependency_cache.py +++ b/src/python/twitter/pants/tasks/jvm_dependency_cache.py @@ -1,5 +1,5 @@ # ================================================================================================== -# Copyright 2011 Twitter, Inc. +# Copyright 2013 Twitter, Inc. # -------------------------------------------------------------------------------------------------- # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this work except in compliance with the License. @@ -19,7 +19,6 @@ import os from collections import defaultdict -from twitter.pants.base.target import Target from twitter.pants.targets.jar_dependency import JarDependency from twitter.pants.targets.jvm_target import JvmTarget from twitter.pants.tasks import TaskError @@ -445,12 +444,7 @@ def check_undeclared_dependencies(self): undeclared_deps, immediate_undeclared_deps = \ self.get_missing_deps_for_target(target, computed_deps, computed_jar_deps, targets_by_class) - - #if len(jar_deps) > 0: - # found_missing_deps = True - # for jd in jar_deps: - # print ("Error: target %s needs to depend on jar_dependency %s.%s" % - # (target.address, jd.org, jd.name)) + found_missing_deps = found_missing_deps or undeclared_deps or immediate_undeclared_deps if self.check_unnecessary_deps and not target.has_label('synthetic'): self.check_unnecessary_deps(target, computed_deps)