More conservative fixes to 4543-entity-caching #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests passing! |
ewinslow
added a commit
that referenced
this pull request
Jun 14, 2012
More conservative fixes to 4543-entity-caching
ewinslow
pushed a commit
that referenced
this pull request
Dec 3, 2012
updated Minify libs, add settings for enabling JS/CSS minification
This was referenced Feb 16, 2013
ewinslow
pushed a commit
that referenced
this pull request
Jun 2, 2013
I think it should respect coding standards now..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't figure out why the recursive object deletion unit is failing. Lines 266 and 270 of engine/tests/objects/objects.php.