Quality loss

[MurKit]

There is a noticeable loss of quality when extracting images with xcur2png compared to opening them and exporting in Gimp.

I added an example image. On the left is Gimp, on the right is an exported image.

[eworm-de]

This is just a copy of the source to archive it. I will not care to close bugs.

[MurKit]

Where's the original repo?

[eworm-de]

The only commit f582d64 has all the details.

[OdinVex]

There is a noticeable loss of quality when extracting images with xcur2png compared to opening them and exporting in Gimp.

I added an example image. On the left is Gimp, on the right is an exported image.

It is due to a math issue assuming 256 instead of 255. Bug fix below:

red = (div (red * 255, alpha).quot) & 0xff;
green = (div (green * 255,  alpha).quot) & 0xff;
blue = (div (blue * 255, alpha).quot) & 0xff;

[eworm-de]

Thanks for investigating... Pushed this in aa03546 to a new branch.

[OdinVex]

Thanks for investigating... Pushed this in aa03546 to a new branch.

Most welcome. Thank you for considering the code.

Edit: It might not hurt to add a bit of information to the repo page regarding the bug-fix for quality loss. Two people have asked me why their quality was poor despite the fix being pushed, and I mentioned they had to clone the repo and build it to get the latest fix because the repo only contains (for posterity?) the original build as a release.