Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot hook should parse fsck exit status #15

Closed
ewxrjk opened this issue Jul 15, 2014 · 0 comments
Closed

Snapshot hook should parse fsck exit status #15

ewxrjk opened this issue Jul 15, 2014 · 0 comments
Assignees
Labels
bug
Milestone

Comments

@ewxrjk
Copy link
Owner

@ewxrjk ewxrjk commented Jul 15, 2014

> rsbackup-snapshot-hook
WARNING: backup of araminta:home to backup5: preBackup: exited with status 1
HOOK: EXEC: umount /snap/home
umount: /snap/home: not mounted
HOOK: EXEC: lvremove --force /dev/mapper/amfast-home.snap
  Logical volume "home.snap" successfully removed
HOOK: EXEC: lvcreate --extents 4710 --name home.snap --snapshot /dev/amfast/home
  Logical volume "home.snap" created
HOOK: EXEC: fsck -a /dev/mapper/amfast-home.snap
fsck from util-linux 2.20.1
/dev/mapper/amfast-home.snap: Clearing orphaned inode 2754454 (uid=1000, gid=100
0, mode=0100644, size=22523)
/dev/mapper/amfast-home.snap: Clearing orphaned inode 2754442 (uid=1000, gid=100
0, mode=0100644, size=22523)
/dev/mapper/amfast-home.snap: Clearing orphaned inode 2754438 (uid=1000, gid=100
0, mode=0100644, size=22523)
/dev/mapper/amfast-home.snap has been mounted 24 times without being checked, ch
eck forced.
/dev/mapper/amfast-home.snap: 609974/6029312 files (0.6% non-contiguous), 796033
3/24117248 blocks
HOOK: EXEC: umount /snap/home
umount: /snap/home: not mounted

The reason is that fsck exits nonzero if errors are corrected (see man page). An exit status of 1 shouldn't be considered fatal (at least with Linux's fsck, but this script uses Linux's LVM...).

Workaround that doesn't involve unmounting: disable snapshots for affected filesystems.

@ewxrjk ewxrjk added this to the 1.1 milestone Jul 15, 2014
@ewxrjk ewxrjk added the bug label Jul 15, 2014
@ewxrjk ewxrjk self-assigned this Jul 15, 2014
@ewxrjk ewxrjk closed this in 07327f2 Jul 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant